Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apk): always append .rsa.pub to key name #808

Merged
merged 1 commit into from
Mar 30, 2024
Merged

fix(apk): always append .rsa.pub to key name #808

merged 1 commit into from
Mar 30, 2024

Conversation

caarlos0
Copy link
Member

closes #806

closes #806

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 29, 2024
Copy link

Deploying nfpm with  Cloudflare Pages  Cloudflare Pages

Latest commit: 38703a5
Status: ✅  Deploy successful!
Preview URL: https://e16a567f.nfpm.pages.dev
Branch Preview URL: https://issue-806.nfpm.pages.dev

View logs

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 72.15%. Comparing base (1667ef9) to head (38703a5).

Files Patch % Lines
apk/apk.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #808      +/-   ##
==========================================
+ Coverage   72.13%   72.15%   +0.02%     
==========================================
  Files          20       20              
  Lines        2232     2234       +2     
==========================================
+ Hits         1610     1612       +2     
  Misses        438      438              
  Partials      184      184              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caarlos0 caarlos0 merged commit 2118e9a into main Mar 30, 2024
40 of 41 checks passed
@caarlos0 caarlos0 deleted the issue-806 branch March 30, 2024 12:36
@github-actions github-actions bot added this to the 2.36.0 milestone Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[apk] Misleading documentation for apk.signature.key_name
1 participant