Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/run command #189

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

boonwj
Copy link
Contributor

@boonwj boonwj commented Apr 5, 2020

Description

This PR introduces the run keyword that will be used to execute user defined commands. This fundamentally changes the way 1build is used.

The previous implementation treats all non-reserved arguments as user defined commands, whereas now the run keyword has to be explicitly provided before 1build treats it as a user defined command.

The motivation for this feature can be found in the issue link.

Fixes/Implements: # (issue)

#179

If New dependencies introduced

N.A

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have update README (If needed)

@auto-comment
Copy link

auto-comment bot commented Apr 5, 2020

🙏 Thank your for raising your pull request.
Please make sure you have followed our contributing guidelines. We will review it as soon as possible

@gopinath-langote
Copy link
Owner

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- cmd/run.go  1
         

Clones added
============
- cmd/run.go  1
         

See the complete overview on Codacy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants