Add support for exporting v1 operations #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry I missed this entirely. I do think we want to split it out, I don't want the v1 service plumbed here. Looks like the common code is the pagination handling and BQ integration mostly? |
tjennison-work
force-pushed
the
dev
branch
3 times, most recently
from
d64f463
to
a2a06b4
Compare
|
I've split off the v1 export into a separate tool, which required moving the client setup and export code into shared packages. |
kemp-google
reviewed
Nov 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We talked about putting this in a separate tool but I'll have to move a bunch of code into shared locations for that so have a look at this first since it's already done. I'll change it if you still want to go that route.