Use Pub/Sub to wait for operation completion #102
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
still brushing up, please hold |
|
I finished testing all the cases, please review. |
| @@ -213,6 +216,13 @@ func runPipeline(ctx context.Context, service *genomics.Service, req *genomics.R | |||
| abort := make(chan os.Signal, 1) | |||
| signal.Notify(abort, os.Interrupt) | |||
|
|
|||
| topic, err := newPubSubTopic(ctx, req.Pipeline.Resources.ProjectId) | |||
There was a problem hiding this comment.
I don't think we want to build topics in the tooling - gcloud can be used for that - I think we just want to support an optional flag.
There was a problem hiding this comment.
I think this is one feature that should be enabled by default. I changed the functionality to always use projects//topics/pipelines-tool if only it has the lable created-by:pipelines-tool. If the tool has any problem in using Pub/Sub it will silently switch to long pooling. Also the user can specify --pub-sub=false to opt for long pooling.
| ) | ||
|
|
||
| func Invoke(ctx context.Context, service *genomics.Service, project string, arguments []string) error { | ||
| names := common.ParseFlags(flags, arguments) | ||
| if len(names) < 1 { | ||
| return errors.New("missing operation name") | ||
| } | ||
| if *topic == "" { |
There was a problem hiding this comment.
We will still want to support polling and I think this doesn't need to be passed: when the operation data is fetched initially if there is a topic we'll start listening instead of polling.
No description provided.