-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Upgrade to later version of gcp-uploader and protobuf #1741
Merged
Merged
Changes from 14 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
8c2bf24
chore: Upgrade to later version of gcp-uploader and protobuf
lqiu96 2609959
chore: Add secretstorage version
lqiu96 a78206c
chore: Use python 3.9.13
lqiu96 e0b8be5
Merge branch 'master' into master-update_synthtool_requirements
lqiu96 234f014
chore: Unpin all python versions
lqiu96 a56d844
chore: Rerun pipcompile tool
lqiu96 07f4ecb
chore: Rerun pipcompile tool with --allow-unsafe
lqiu96 09fa74d
chore: Add --require-hashes
lqiu96 bd22b68
chore: Update requirements file
lqiu96 9fe9009
chore: Remove --require-hashes
lqiu96 629f92d
chore: Print python version
lqiu96 90bff51
chore: Add new generated hashes for requirements.txt
lqiu96 20e588d
chore: Remove python version check in cloud build
lqiu96 477f6ca
chore: Allow synthtool to update python dependencies
lqiu96 9bdb449
chore: Add typing-extensions into requirements
lqiu96 9f2e13f
chore: Unpin docker requirements.in file
lqiu96 30ab721
chore: Add java synthtool validation
lqiu96 0c657ea
chore: Add check to import java synthtool python package
lqiu96 f61cfeb
Merge branch 'master' into master-update_synthtool_requirements
lqiu96 e0e5463
Merge branch 'master' into master-update_synthtool_requirements
lqiu96 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 changes: 5 additions & 34 deletions
39
synthtool/gcp/templates/java_library/.kokoro/requirements.in
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,34 +1,5 @@ | ||
gcp-docuploader==0.6.3 | ||
google-crc32c==1.3.0 | ||
googleapis-common-protos==1.56.3 | ||
gcp-releasetool==1.9.1 | ||
cryptography==38.0.3 | ||
cachetools==4.2.4 | ||
cffi==1.15.1 | ||
jeepney==0.7.1 | ||
jinja2==3.0.3 | ||
markupsafe==2.0.1 | ||
keyring==23.4.1 | ||
packaging==21.3 | ||
protobuf==3.19.5 | ||
pyjwt==2.4.0 | ||
pyparsing==3.0.9 | ||
pycparser==2.21 | ||
pyperclip==1.8.2 | ||
python-dateutil==2.8.2 | ||
requests==2.27.1 | ||
certifi==2022.12.7 | ||
importlib-metadata==4.8.3 | ||
zipp==3.6.0 | ||
google_api_core==2.8.2 | ||
google-cloud-storage==2.0.0 | ||
google-resumable-media==2.3.3 | ||
google-cloud-core==2.3.1 | ||
typing-extensions==4.1.1 | ||
urllib3==1.26.12 | ||
zipp==3.6.0 | ||
rsa==4.9 | ||
six==1.16.0 | ||
attrs==22.1.0 | ||
google-auth==2.14.1 | ||
idna==3.4 | ||
gcp-docuploader | ||
gcp-releasetool | ||
wheel | ||
setuptools | ||
click<8.1.0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lqiu96 Would you add an assertion that this python module
synthtool.languages.java
is available? I think it would look like this:An example failure would look like this:
It gives more confidence that a change for OwlBot Postprocessor works fine in owlbot.py (example location)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I can add that validation in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the new validation in as
java synthtool validation
which runs the commands above.FYI, couldn't find the docs for
schemaVersion
1.0.0 and the docs on https://github.com/GoogleContainerTools/container-structure-test were showing docs for2.0.0
, so I used that for local testingThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.