Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: inline disclaimer comment, use Sample/RegionTag, collect GapicClass samples #925

Closed
wants to merge 16 commits into from

Conversation

eaball35
Copy link
Contributor

@eaball35 eaball35 commented Feb 9, 2022

pt2
go/java-sample-gen

  • update current generated sample composers to utilize Sample and Region Tag
  • update inline samples to include disclaimer comment
  • add samples as attribute of GapicClass - collect all generated samples while generating class
  • merging this PR will change generation: - disclaimer comment included with inline samples

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Feb 9, 2022
@snippet-bot
Copy link

snippet-bot bot commented Feb 9, 2022

Here is the summary of possible violations 😱

There are 125 possible violations for not having product prefix.

The end of the violation section. All the stuff below is FYI purposes only.


Here is the summary of changes.

You are about to add 125 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #925 (7a8048d) into main (2a3df94) will increase coverage by 0.09%.
The diff coverage is 91.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #925      +/-   ##
==========================================
+ Coverage   87.37%   87.46%   +0.09%     
==========================================
  Files         162      165       +3     
  Lines       16307    16729     +422     
  Branches     1179     1194      +15     
==========================================
+ Hits        14248    14632     +384     
- Misses       1717     1744      +27     
- Partials      342      353      +11     
Impacted Files Coverage Δ
...i/generator/engine/writer/ImportWriterVisitor.java 94.56% <ø> (+1.61%) ⬆️
...pic/composer/ClientLibraryPackageInfoComposer.java 0.00% <0.00%> (ø)
...c/composer/samplecode/SampleCodeJavaFormatter.java 100.00% <ø> (ø)
...er/samplecode/ServiceClientSampleCodeComposer.java 96.32% <88.38%> (-2.97%) ⬇️
...r/common/AbstractServiceSettingsClassComposer.java 97.57% <90.00%> (-0.15%) ⬇️
...mmon/AbstractServiceStubSettingsClassComposer.java 96.15% <90.00%> (-0.06%) ⬇️
...ser/common/AbstractServiceClientClassComposer.java 98.38% <90.90%> (-0.24%) ⬇️
...m/google/api/generator/gapic/model/GapicClass.java 97.50% <96.87%> (-2.50%) ⬇️
...ator/gapic/composer/samplecode/SampleComposer.java 97.80% <97.80%> (ø)
...erator/gapic/composer/comment/CommentComposer.java 92.85% <100.00%> (+5.35%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a3df94...7a8048d. Read the comment docs.

@eaball35 eaball35 marked this pull request as ready for review February 10, 2022 03:18
@eaball35 eaball35 requested review from a team as code owners February 10, 2022 03:18
@eaball35 eaball35 closed this Feb 15, 2022
@eaball35 eaball35 deleted the javasamplegen_2 branch February 15, 2022 03:58
suztomo pushed a commit that referenced this pull request Mar 21, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.api.grpc:grpc-google-iam-v1](https://togithub.com/googleapis/java-iam/grpc-google-iam-v1) ([source](https://togithub.com/googleapis/java-iam)) | `1.6.16` -> `1.6.17` | [![age](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:grpc-google-iam-v1/1.6.17/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:grpc-google-iam-v1/1.6.17/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:grpc-google-iam-v1/1.6.17/compatibility-slim/1.6.16)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:grpc-google-iam-v1/1.6.17/confidence-slim/1.6.16)](https://docs.renovatebot.com/merge-confidence/) |
| [com.google.api.grpc:proto-google-iam-v1](https://togithub.com/googleapis/java-iam/proto-google-iam-v1) ([source](https://togithub.com/googleapis/java-iam)) | `1.6.16` -> `1.6.17` | [![age](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-iam-v1/1.6.17/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-iam-v1/1.6.17/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-iam-v1/1.6.17/compatibility-slim/1.6.16)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-iam-v1/1.6.17/confidence-slim/1.6.16)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-iam</summary>

### [`v1.6.17`](https://togithub.com/googleapis/java-iam/blob/HEAD/CHANGELOG.md#&#8203;1617-httpsgithubcomgoogleapisjava-iamcomparev1616v1617-2022-11-21)

[Compare Source](https://togithub.com/googleapis/java-iam/compare/v1.6.16...v1.6.17)

##### Dependencies

-   Update dependency com.google.cloud:google-iam-policy to v1.6.16 ([#&#8203;542](https://togithub.com/googleapis/java-iam/issues/542)) ([deca3f1](https://togithub.com/googleapis/java-iam/commit/deca3f14b9ead487536cb7c94a20dc4c26800a2b))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-shared-dependencies).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yOS4yIiwidXBkYXRlZEluVmVyIjoiMzQuMjkuMiJ9-->
suztomo pushed a commit that referenced this pull request Mar 21, 2023
….6.0 (#925)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.api.grpc:proto-google-iam-v1](https://togithub.com/googleapis/java-iam/proto-google-iam-v1) ([source](https://togithub.com/googleapis/java-iam)) | `1.5.2` -> `1.6.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-iam-v1/1.6.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-iam-v1/1.6.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-iam-v1/1.6.0/compatibility-slim/1.5.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-iam-v1/1.6.0/confidence-slim/1.5.2)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-iam</summary>

### [`v1.6.0`](https://togithub.com/googleapis/java-iam/blob/HEAD/CHANGELOG.md#&#8203;160-httpsgithubcomgoogleapisjava-iamcomparev152v160-2022-09-20)

[Compare Source](https://togithub.com/googleapis/java-iam/compare/v1.5.2...v1.6.0)

##### Features

-   Add v2 client ([#&#8203;423](https://togithub.com/googleapis/java-iam/issues/423)) ([6b6c24f](https://togithub.com/googleapis/java-iam/commit/6b6c24f11093d2ccc5e5005337576db7c9626ec0))
-   Update the public IAM Deny v2beta API ([5894873](https://togithub.com/googleapis/java-iam/commit/58948731feee6462ae75f6fe11c31e36e9ec6fce))

##### Documentation

-   **samples:** Update param values ([#&#8203;401](https://togithub.com/googleapis/java-iam/issues/401)) ([8879c28](https://togithub.com/googleapis/java-iam/commit/8879c28cac3543c441be636da626bcc3c10509da))

##### Dependencies

-   Update dependency com.google.apis:google-api-services-cloudresourcemanager to v3-rev20220710-1.32.1 ([#&#8203;383](https://togithub.com/googleapis/java-iam/issues/383)) ([0670b46](https://togithub.com/googleapis/java-iam/commit/0670b461db649b2be307735aa128e8273d42d38f))
-   Update dependency com.google.apis:google-api-services-cloudresourcemanager to v3-rev20220710-2.0.0 ([#&#8203;396](https://togithub.com/googleapis/java-iam/issues/396)) ([ec96383](https://togithub.com/googleapis/java-iam/commit/ec96383900c271ddf96a58772ff459c6879c106f))
-   Update dependency com.google.apis:google-api-services-cloudresourcemanager to v3-rev20220731-2.0.0 ([#&#8203;402](https://togithub.com/googleapis/java-iam/issues/402)) ([39605e5](https://togithub.com/googleapis/java-iam/commit/39605e5b1cb4ee9fea068e36a6452e02710ae03d))
-   Update dependency com.google.apis:google-api-services-cloudresourcemanager to v3-rev20220807-2.0.0 ([#&#8203;407](https://togithub.com/googleapis/java-iam/issues/407)) ([475fa93](https://togithub.com/googleapis/java-iam/commit/475fa93c1b5affb19eec36856e719041d5bf56af))
-   Update dependency com.google.apis:google-api-services-cloudresourcemanager to v3-rev20220828-2.0.0 ([#&#8203;417](https://togithub.com/googleapis/java-iam/issues/417)) ([f3b365d](https://togithub.com/googleapis/java-iam/commit/f3b365df695b61515871c24dd2d14cde015ad599))
-   Update dependency com.google.apis:google-api-services-iam to v2beta-rev20220713-1.32.1 ([#&#8203;390](https://togithub.com/googleapis/java-iam/issues/390)) ([9bef280](https://togithub.com/googleapis/java-iam/commit/9bef280b9c871ad9333daa8f027b8679f91ccbb1))
-   Update dependency com.google.apis:google-api-services-iam to v2beta-rev20220713-2.0.0 ([#&#8203;403](https://togithub.com/googleapis/java-iam/issues/403)) ([7a8270b](https://togithub.com/googleapis/java-iam/commit/7a8270b691b5c749c90185659bd3a51480c3e1c4))
-   Update dependency com.google.apis:google-api-services-iamcredentials to v1-rev20211203-2.0.0 ([#&#8203;404](https://togithub.com/googleapis/java-iam/issues/404)) ([ee3537d](https://togithub.com/googleapis/java-iam/commit/ee3537d763c389d25d887fb1b2cfc61ff4101d65))
-   Update dependency com.google.auth:google-auth-library-oauth2-http to v1.10.0 ([#&#8203;406](https://togithub.com/googleapis/java-iam/issues/406)) ([56284df](https://togithub.com/googleapis/java-iam/commit/56284df32ee657a5055e6dea3bd7b25772c218ea))
-   Update dependency com.google.auth:google-auth-library-oauth2-http to v1.11.0 ([#&#8203;419](https://togithub.com/googleapis/java-iam/issues/419)) ([3375ba3](https://togithub.com/googleapis/java-iam/commit/3375ba3a5b44d97370233238a63e1a310b5b605a))
-   Update dependency com.google.auth:google-auth-library-oauth2-http to v1.8.1 ([#&#8203;385](https://togithub.com/googleapis/java-iam/issues/385)) ([e6199b3](https://togithub.com/googleapis/java-iam/commit/e6199b3c094f606359c8e469a853a283cd82c836))
-   Update dependency com.google.auth:google-auth-library-oauth2-http to v1.9.0 ([#&#8203;400](https://togithub.com/googleapis/java-iam/issues/400)) ([aa4e5b6](https://togithub.com/googleapis/java-iam/commit/aa4e5b6ec5af98925c4353c9393e33c423c67a60))
-   Update dependency com.google.cloud:google-cloud-shared-dependencies to v3 ([#&#8203;395](https://togithub.com/googleapis/java-iam/issues/395)) ([a88edd6](https://togithub.com/googleapis/java-iam/commit/a88edd61e1a66c5f48185dd5e8a2a61e5e9a002e))
-   Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.1 ([#&#8203;399](https://togithub.com/googleapis/java-iam/issues/399)) ([bf814a9](https://togithub.com/googleapis/java-iam/commit/bf814a9faf878195676937cfe793b4a20fff6f06))
-   Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#&#8203;420](https://togithub.com/googleapis/java-iam/issues/420)) ([e358921](https://togithub.com/googleapis/java-iam/commit/e358921e5ade85359a97b6a19af7a8397227c428))
-   Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([#&#8203;426](https://togithub.com/googleapis/java-iam/issues/426)) ([6da2bd2](https://togithub.com/googleapis/java-iam/commit/6da2bd228c5e3b9f6d9d35e95b955c7fbd65807d))
-   Update dependency com.google.http-client:google-http-client-jackson2 to v1.42.2 ([#&#8203;386](https://togithub.com/googleapis/java-iam/issues/386)) ([de1b271](https://togithub.com/googleapis/java-iam/commit/de1b27180bf93a5c9b5a9a274f9d5a2c2ff5afc1))
-   Update dependency com.google.protobuf:protobuf-java to v3.21.3 ([#&#8203;391](https://togithub.com/googleapis/java-iam/issues/391)) ([02a3c56](https://togithub.com/googleapis/java-iam/commit/02a3c56b1143d497b98e2f437d9b36ea468e36ea))
-   Update dependency com.google.protobuf:protobuf-java to v3.21.4 ([#&#8203;393](https://togithub.com/googleapis/java-iam/issues/393)) ([f4c649b](https://togithub.com/googleapis/java-iam/commit/f4c649b67c0a8fa950487b3e3b2f10ab85136165))
-   Update dependency com.google.protobuf:protobuf-java to v3.21.5 ([#&#8203;405](https://togithub.com/googleapis/java-iam/issues/405)) ([66b27cb](https://togithub.com/googleapis/java-iam/commit/66b27cb9722cac68af7844447524f149fb08b3b0))
-   Update dependency io.grpc:grpc-protobuf to v1.48.0 ([#&#8203;388](https://togithub.com/googleapis/java-iam/issues/388)) ([d7beea4](https://togithub.com/googleapis/java-iam/commit/d7beea4de4aff35f998b017c6d6136c76ec1e36b))
-   Update dependency io.grpc:grpc-protobuf to v1.48.1 ([#&#8203;397](https://togithub.com/googleapis/java-iam/issues/397)) ([512a655](https://togithub.com/googleapis/java-iam/commit/512a6554067bbbe9ac400f833a0a8cd4bfaef785))
-   Update dependency io.grpc:grpc-protobuf to v1.49.0 ([#&#8203;413](https://togithub.com/googleapis/java-iam/issues/413)) ([93ac43d](https://togithub.com/googleapis/java-iam/commit/93ac43deb5a663bd22b5d14f8ba7a4bdff6928cd))
-   Update dependency io.grpc:grpc-protobuf to v1.49.1 ([#&#8203;427](https://togithub.com/googleapis/java-iam/issues/427)) ([c7b26dd](https://togithub.com/googleapis/java-iam/commit/c7b26dd62e4b22634f15e4eb19d96c3dfc919d11))
-   Update dependency io.grpc:grpc-stub to v1.48.0 ([#&#8203;389](https://togithub.com/googleapis/java-iam/issues/389)) ([c76beb0](https://togithub.com/googleapis/java-iam/commit/c76beb01ba7a59cdfe60fc498f33881faadafe89))
-   Update dependency io.grpc:grpc-stub to v1.48.1 ([#&#8203;398](https://togithub.com/googleapis/java-iam/issues/398)) ([4917a59](https://togithub.com/googleapis/java-iam/commit/4917a59ae856825e6e96a5b3ca0d766b8a931de6))
-   Update dependency io.grpc:grpc-stub to v1.49.0 ([#&#8203;414](https://togithub.com/googleapis/java-iam/issues/414)) ([1d98460](https://togithub.com/googleapis/java-iam/commit/1d9846000bf41f20907dfcbc11574e88f91cc8f8))
-   Update dependency io.grpc:grpc-stub to v1.49.1 ([#&#8203;428](https://togithub.com/googleapis/java-iam/issues/428)) ([ad6f449](https://togithub.com/googleapis/java-iam/commit/ad6f449c6fdfbf91a89561359ef2f124e9d8dfa2))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xOTguMSIsInVwZGF0ZWRJblZlciI6IjMyLjE5OC4xIn0=-->
suztomo pushed a commit that referenced this pull request Mar 21, 2023
🤖 I have created a release *beep* *boop*
---


## [2.8.15](googleapis/java-core@v2.8.14...v2.8.15) (2022-09-23)


### Dependencies

* Update dependency com.google.api.grpc:proto-google-iam-v1 to v1.6.0 ([#925](googleapis/java-core#925)) ([88a8523](googleapis/java-core@88a8523))
* Update dependency com.google.api.grpc:proto-google-iam-v1 to v1.6.1 ([#926](googleapis/java-core#926)) ([9f348aa](googleapis/java-core@9f348aa))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant