Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update protobuf dependencies - abandoned #3066

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Jul 24, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence Type Update
com.google.protobuf:protobuf-java (source) 3.25.3 -> 3.25.4 age adoption passing confidence patch
protocolbuffers/protobuf 25.3 -> 25.4 age adoption passing confidence minor
com.google.protobuf:protobuf-bom (source) 3.25.3 -> 3.25.4 age adoption passing confidence import patch

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Release Notes

protocolbuffers/protobuf (com.google.protobuf:protobuf-java)

v3.25.4


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 24, 2024
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jul 24, 2024
@renovate-bot renovate-bot force-pushed the renovate/protobuf-dependencies branch from a47fef8 to 424f5ce Compare July 24, 2024 22:40
@renovate-bot renovate-bot changed the title deps: update dependency protocolbuffers/protobuf to v25.4 deps: update protobuf dependencies Jul 24, 2024
@renovate-bot renovate-bot force-pushed the renovate/protobuf-dependencies branch from 424f5ce to 18764af Compare July 25, 2024 21:27
@renovate-bot renovate-bot force-pushed the renovate/protobuf-dependencies branch 2 times, most recently from 6525961 to 6f9fc9a Compare August 14, 2024 18:13
@mpeddada1
Copy link
Contributor

/gcbrun

@mpeddada1
Copy link
Contributor

Golden tests failing with:

-// Protobuf Java Version: 3.25.3
+// Protobuf Java Version: 3.25.4
 package com.google.showcase.v1beta1;
 
 /**
diff -ru /home/runner/work/sdk-platform-java/sdk-platform-java/showcase/scripts/../proto-gapic-showcase-v1beta1/src/main/java/com/google/showcase/v1beta1/WaitResponseOrBuilder.java /home/runner/work/sdk-platform-java/sdk-platform-java/showcase/scripts/output/showcase-output/proto-showcase-output/src/main/java/com/google/showcase/v1beta1/WaitResponseOrBuilder.java
--- /home/runner/work/sdk-platform-java/sdk-platform-java/showcase/scripts/../proto-gapic-showcase-v1beta1/src/main/java/com/google/showcase/v1beta1/WaitResponseOrBuilder.java	2024-08-15 18:48:40.985798738 +0000
+++ /home/runner/work/sdk-platform-java/sdk-platform-java/showcase/scripts/output/showcase-output/proto-showcase-output/src/main/java/com/google/showcase/v1beta1/WaitResponseOrBuilder.java	2024-08-15 18:50:25.602175426 +0000
@@ -1,7 +1,7 @@
 // Generated by the protocol buffer compiler.  DO NOT EDIT!
 // source: schema/google/showcase/v1beta1/echo.proto
 
-// Protobuf Java Version: 3.25.3
+// Protobuf Java Version: 3.25.4
 package com.google.showcase.v1beta1;
 

Copy link

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

Copy link

sonarcloud bot commented Aug 15, 2024

Copy link

sonarcloud bot commented Aug 15, 2024

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@blakeli0
Copy link
Collaborator

Golden tests failing with:

-// Protobuf Java Version: 3.25.3
+// Protobuf Java Version: 3.25.4
 package com.google.showcase.v1beta1;
 
 /**
diff -ru /home/runner/work/sdk-platform-java/sdk-platform-java/showcase/scripts/../proto-gapic-showcase-v1beta1/src/main/java/com/google/showcase/v1beta1/WaitResponseOrBuilder.java /home/runner/work/sdk-platform-java/sdk-platform-java/showcase/scripts/output/showcase-output/proto-showcase-output/src/main/java/com/google/showcase/v1beta1/WaitResponseOrBuilder.java
--- /home/runner/work/sdk-platform-java/sdk-platform-java/showcase/scripts/../proto-gapic-showcase-v1beta1/src/main/java/com/google/showcase/v1beta1/WaitResponseOrBuilder.java	2024-08-15 18:48:40.985798738 +0000
+++ /home/runner/work/sdk-platform-java/sdk-platform-java/showcase/scripts/output/showcase-output/proto-showcase-output/src/main/java/com/google/showcase/v1beta1/WaitResponseOrBuilder.java	2024-08-15 18:50:25.602175426 +0000
@@ -1,7 +1,7 @@
 // Generated by the protocol buffer compiler.  DO NOT EDIT!
 // source: schema/google/showcase/v1beta1/echo.proto
 
-// Protobuf Java Version: 3.25.3
+// Protobuf Java Version: 3.25.4
 package com.google.showcase.v1beta1;
 

I think this is an unexpected change from hermetic build that the showcase module is now automatically generated with the protobuf runtime version specified in the pom.
In the past, the protobuf runtime and protoc updates were done in separate PRs, hence it would not introduce this problem. But it has other problems that a new version of protobuf runtime may not be compatible with the older protoc generated code.
In the future, I think it is better to always keep them in sync(as suggested by protobuf team) but we may still want to have the flexibility of only updating one of them.
I see that a manual PR was created to resolve this issue, I think we can continue this manual approach for now, but we should migrate showcase to use hermetic build image so that the protoc generated code change would come together with java-common-protos and iam. cc: @JoeWang1127 @diegomarquezp

@renovate-bot renovate-bot changed the title deps: update protobuf dependencies deps: update protobuf dependencies - abandoned Aug 15, 2024
Copy link

Autoclosing Skipped

This PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error.

@ldetmer ldetmer closed this Sep 5, 2024
@ldetmer
Copy link
Contributor

ldetmer commented Sep 5, 2024

Closed as protobuf dependency was manually updated in this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kokoro:force-run Add this label to force Kokoro to re-run the tests. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants