Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove google/shopping/type/types.proto when generating shopping APIs #2554

Merged
merged 3 commits into from
Mar 13, 2024

Conversation

JoeWang1127
Copy link
Collaborator

After #2553 is merged, we do not need to add google/shopping/type/types.proto in generate_library.sh as a special case.

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Mar 11, 2024
@JoeWang1127 JoeWang1127 added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 12, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 12, 2024
@diegomarquezp
Copy link
Contributor

The owl-bot-copy output does not show rm statements for some reason

@JoeWang1127 JoeWang1127 marked this pull request as ready for review March 12, 2024 21:46
@JoeWang1127 JoeWang1127 requested a review from a team as a code owner March 12, 2024 21:46
@JoeWang1127 JoeWang1127 enabled auto-merge (squash) March 12, 2024 21:48
Copy link

sonarcloud bot commented Mar 12, 2024

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Mar 12, 2024

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@JoeWang1127 JoeWang1127 merged commit 60cb67f into main Mar 13, 2024
31 checks passed
@JoeWang1127 JoeWang1127 deleted the chore/remove-shopping-type branch March 13, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants