Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: include use of x-version-update annotation in abitrary file documentation #2196

Closed
wants to merge 1 commit into from

Conversation

mpeddada1
Copy link

As seen in googleapis/sdk-platform-java#2351, the x-version-update annotation can also be used to update versions in arbitrary files using release-please.

@mpeddada1 mpeddada1 requested review from a team as code owners January 16, 2024 21:48
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jan 16, 2024
@mpeddada1 mpeddada1 changed the title chore: include use of x-version-update annotation in abitrary file documentation docs: include use of x-version-update annotation in abitrary file documentation Jan 24, 2024
Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is tricky, because it's only available to the java-yoshi strategy. In general, the community shouldn't be using this strategy as it's custom to our internal needs.

At some point if/when we get dynamic plugins implemented, then we can pull all of our custom strategies into their own sub-library and document these nuances there.

@chingor13 chingor13 closed this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants