Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: treat warnings as errors #463

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

build: treat warnings as errors #463

wants to merge 6 commits into from

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Dec 11, 2023

No description provided.

@parthea parthea requested review from a team as code owners December 11, 2023 15:29
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: pubsublite Issues related to the googleapis/python-pubsublite API. labels Dec 11, 2023
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Dec 11, 2023
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: s Pull request size is small. labels Jan 24, 2024
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Jan 24, 2024
acocuzzo
acocuzzo approved these changes Apr 12, 2024
View reviewed changes
Copy link

@acocuzzo acocuzzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @parthea

@acocuzzo acocuzzo added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 17, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelpri10 michaelpri10 michaelpri10 approved these changes

@acocuzzo acocuzzo acocuzzo approved these changes

Assignees

@parthea parthea

Labels
api: pubsublite Issues related to the googleapis/python-pubsublite API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@parthea @michaelpri10 @acocuzzo @yoshi-kokoro @hannahrogers-google