Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add support for Classifier entities #333

Merged
merged 7 commits into from
Jul 16, 2024
Merged

fix: Add support for Classifier entities #333

merged 7 commits into from
Jul 16, 2024

Conversation

holtskinner
Copy link
Member

@holtskinner holtskinner commented Jul 11, 2024 •
edited
Loading

  • Added support for Custom Classifier entities
  • Added Unit Tests for Classifier output
  • Added input validation for Document.split_pdf()

Fixes #332 🦕

@holtskinner holtskinner requested review from a team as code owners July 11, 2024 17:11
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jul 11, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Jul 11, 2024
@holtskinner holtskinner enabled auto-merge (squash) July 11, 2024 17:37
dizcology
dizcology approved these changes Jul 16, 2024
View reviewed changes
google/cloud/documentai_toolbox/wrappers/entity.py Show resolved Hide resolved
google/cloud/documentai_toolbox/wrappers/entity.py Outdated Show resolved Hide resolved
google/cloud/documentai_toolbox/wrappers/entity.py Outdated Show resolved Hide resolved
tests/unit/test_entity.py Show resolved Hide resolved
@holtskinner holtskinner merged commit 2352cae into main Jul 16, 2024
22 checks passed
@holtskinner holtskinner deleted the classifier-fix branch July 16, 2024 18:24
@release-please release-please bot mentioned this pull request Jul 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dizcology dizcology dizcology approved these changes

Assignees

@dizcology dizcology

Labels
size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document.entities field is unusable when using data from Classifier output
3 participants
@holtskinner @dizcology @nayaknishant