-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Copy Backup #680
base: main
Are you sure you want to change the base?
feat: Copy Backup #680
Conversation
Allow copying a Backup.
d5f872f
to
f8c9433
Compare
|
||
return api.copy_backup( | ||
request={ | ||
"parent": parent, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how does this work if the source backup project and parent backup project are different?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
parent
is constructed using project_id
, instance_id
, cluster_id
. It's allowed to be different I believe as long as the user have access to both. I'm not seeing any restriction about it from the design doc. From the client we will pass the path, and relay back error from the server.
tests/system/test_table_admin.py
Outdated
@@ -323,6 +324,27 @@ def test_table_backup( | |||
temp_table_backup.expire_time | |||
) | |||
|
|||
# Testing `backup.copy()` method | |||
backup_op = temp_backup.copy("copied-backup") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also add some test cases with some of the other parameters set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added tests that pass additional parameters.
No description provided.