Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] chore: add cross_sync annotations #1000

Draft
wants to merge 52 commits into
base: cross_sync2_pr1_architecture
Choose a base branch
from

Conversation

daniel-sanche
Copy link
Contributor

@daniel-sanche daniel-sanche commented Jul 18, 2024

PR 2/x for adding the sync surface for the new data client

This PR restructures the existing async library to better support the sync side. Specifically:

  • all async-specific calls and types are replaced with corresponding calls to the new CrossSync class, which simply contains a set of aliases pointing back at the corresponding async functionality
  • all async keywords are annotated with CrossSync.rm_aio, which tells the ast transformers where to strip out asyncio keywords

Currently, we need to run the conversion process manually (using python .cross_sync/generate.py, and the sync files are not included in the codebase. The next PR will add the sync artifacts, and add the generation pipeline into the CI system

@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: bigtable Issues related to the googleapis/python-bigtable API. labels Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/python-bigtable API. size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant