-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT] chore: add cross_sync annotations #1000
Draft
daniel-sanche
wants to merge
52
commits into
cross_sync2_pr1_architecture
Choose a base branch
from
cross_sync2_pr2_annotations
base: cross_sync2_pr1_architecture
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[DRAFT] chore: add cross_sync annotations #1000
daniel-sanche
wants to merge
52
commits into
cross_sync2_pr1_architecture
from
cross_sync2_pr2_annotations
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 37b4833.
product-auto-label
bot
added
size: xl
Pull request size is extra large.
api: bigtable
Issues related to the googleapis/python-bigtable API.
labels
Jul 18, 2024
daniel-sanche
force-pushed
the
cross_sync2_pr2_annotations
branch
from
August 13, 2024 00:50
abc7a7a
to
ceabe03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: bigtable
Issues related to the googleapis/python-bigtable API.
size: xl
Pull request size is extra large.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 2/x for adding the sync surface for the new data client
This PR restructures the existing async library to better support the sync side. Specifically:
Currently, we need to run the conversion process manually (using
python .cross_sync/generate.py
, and the sync files are not included in the codebase. The next PR will add the sync artifacts, and add the generation pipeline into the CI system