-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add .readme-metadata.json and generate new README.md #595
Conversation
Codecov Report
@@ Coverage Diff @@
## master #595 +/- ##
=========================================
- Coverage 92.07% 91.97% -0.1%
=========================================
Files 25 25
Lines 2057 2057
Branches 167 167
=========================================
- Hits 1894 1892 -2
- Misses 142 144 +2
Partials 21 21
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #595 +/- ##
=======================================
Coverage 92.07% 92.07%
=======================================
Files 25 25
Lines 2057 2057
Branches 167 167
=======================================
Hits 1894 1894
Misses 142 142
Partials 21 21 Continue to review full report at Codecov.
|
@callmehiphop @busunkim96 @jkwlui this pull should now be ready for review. |
|
||
View the [source code](https://github.com/googleapis/nodejs-firestore/blob/master/samples/quickstart.js). | ||
|
||
[![Open in Cloud Shell][shell_img]](https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/googleapis/nodejs-firestore&page=editor&open_in_editor=samples/quickstart.js,samples/README.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after discussion with @JustinBeckwith last week, we opted to significantly simplify the samples README.md, until we can pull in more information from DRIFT.
This pull request introduces the
.repo-metadata.json
, which @busunkim96 has been working on defining, and re-generates our README based on it.this isn't quite ready yet, we need to figure out how we're getting a bit more information for samples READMEs.