[fix]: allow async functions in transactions #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
schmidt-sebastian
changed the title
Codecov Report
@@ Coverage Diff @@
## master #576 +/- ##
=======================================
Coverage 96.01% 96.01%
=======================================
Files 24 24
Lines 1955 1955
Branches 169 168 -1
=======================================
Hits 1877 1877
Misses 57 57
Partials 21 21
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #576 +/- ##
=======================================
Coverage 96.01% 96.01%
=======================================
Files 24 24
Lines 1955 1955
Branches 169 168 -1
=======================================
Hits 1877 1877
Misses 57 57
Partials 21 21
Continue to review full report at Codecov.
|
JustinBeckwith
approved these changes
Mar 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #574.
The
toString()call on an async function produces [object AsyncFunction] instead of [object Function]. This PR replaces the toString() check with the same typeof check we use in the Web SDK, which returns "function" for both. See lodash/lodash#2768 for other examples of the same issue.Note: The lack of tests in this PR is due to the fact that we still support Node 6 and don't use async/await in the transpiled code. It is therefore impossible to write an async Function that would trigger this failure.