Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making .dogChanges a method #324

Merged
merged 1 commit into from
Aug 20, 2018
Merged

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Aug 20, 2018

Porting the dogChanges API change from the Web SDK.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 20, 2018
@schmidt-sebastian schmidt-sebastian changed the title Making .dotChanges a method Making .dogChanges a method Aug 20, 2018
@codecov
Copy link

codecov bot commented Aug 20, 2018

Codecov Report

Merging #324 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #324   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          10     10           
  Lines        1875   1881    +6     
  Branches      381    382    +1     
=====================================
+ Hits         1875   1881    +6
Impacted Files Coverage Δ
dev/src/reference.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 067c897...7aa0bfd. Read the comment docs.

Copy link

@zxu123 zxu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants