-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unhide APIs and enable tests #1869
Conversation
@MarkDuckworth this PR is merging into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like one additional member that needs to be made public, but otherwise it's good to go.
The CI is expected to fail. |
* Enable tests. * Remove @internal annotation. * Address comments.
* feat: Sum and Average Aggregations. (#1831) * WIP WIP. * also add isEqual. * lint. * add aggregate() API in firestore.d.ts. * Use NodeJS.Dict * Update isEqual. * Add isEqual unit test. * better api. * more tests. * Add more tests. * Remove test code that targets emulator. * rename avg() to average(). * rename avg to average. * Fix lint errors. * Clean up. * Address code review comments. * Expose aggregate type and field publicly. * Fix the way assert was imported. * lint. * backport test updates. * feat: Add long-alias support for aggregations. (#1844) * feat: Add long-alias support for aggregations. * Lint fix and fix unit tests. * update assertion message. * Unhide APIs and enable tests (#1869) * Enable tests. * Remove @internal annotation. * Address comments. * Address comments. * Removing AggregateField.field from new api. * Fix failing test assertion with REST transport. * Fix test query. * Add more tests with cursors. * prettier. * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Mark Duckworth <1124037+MarkDuckworth@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
All tests pass.