Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: Don't allow serialization of firestore settings (#1742)
* Dont allow serialization of firestore settings When logging any firestore object like WriteBatch,Transaction,etc the settings object also gets logged / exposed This can be seen by running JSON.stringify on any firestore object even a document reference Many developers log firestore objects to help them debug testing/prod issues, this leaking of entire firestore key via this._settings is a bad practice as per me We can also use Object.defineProperty to make it non-enumerable or any other technique that you like * Fix formatting. * Only redact credentials. Co-authored-by: Ehsan Nasiri <ehsannas@gmail.com>
- Loading branch information