Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(samples): split samples into their own files #368

Merged
merged 8 commits into from
Mar 8, 2019
Merged

refactor(samples): split samples into their own files #368

merged 8 commits into from
Mar 8, 2019

Conversation

steffnay
Copy link
Contributor

@steffnay steffnay commented Mar 6, 2019

Fixes #367

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 6, 2019
@steffnay steffnay marked this pull request as ready for review March 6, 2019 20:00
Copy link
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on the first PR in this repo! When filing PRs in nodejs land, we really like to use the conventional commits format. It makes things a lot easier when figuring out what's happening in a change log.

Could you rename this PR (and the resulting commit) to something like:
refactor(samples): split samples into their own files

Thanks!

samples/bigquery_create_dataset.js Outdated Show resolved Hide resolved
samples/bigquery_create_dataset.js Outdated Show resolved Hide resolved
samples/test/datasets.test.js Show resolved Hide resolved
@steffnay steffnay changed the title Standards update refactor(samples): split samples into their own files Mar 7, 2019
@codecov
Copy link

codecov bot commented Mar 8, 2019

Codecov Report

Merging #368 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #368   +/-   ##
=======================================
  Coverage   99.44%   99.44%           
=======================================
  Files           4        4           
  Lines         544      544           
  Branches       75       75           
=======================================
  Hits          541      541           
  Misses          2        2           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54e8df3...912d275. Read the comment docs.

@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 8, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 8, 2019
@JustinBeckwith JustinBeckwith merged commit fdd851f into googleapis:master Mar 8, 2019
samples/bigquery_create_dataset.js Show resolved Hide resolved
samples/bigquery_create_dataset.js Show resolved Hide resolved
samples/bigquery_create_dataset.js Show resolved Hide resolved
samples/bigquery_delete_dataset.js Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants