chore: make test prefix unique per run #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
stephenplusplus
suggested changes
Feb 28, 2019
Codecov Report
@@ Coverage Diff @@
## master #363 +/- ##
=========================================
Coverage ? 99.44%
=========================================
Files ? 4
Lines ? 544
Branches ? 75
=========================================
Hits ? 541
Misses ? 2
Partials ? 1Continue to review full report at Codecov.
|
JustinBeckwith
approved these changes
Feb 28, 2019
|
Ok! I figured out what is going on. We shouldn't change the prefix that we filter on. We use that to delete accidentally-created, stale datasets from previous test runs. Instead, we should only delete ones that are > 24 hours old, for example. That way, we'll avoid parallel CI-run collisions. |
stephenplusplus
added a commit
that referenced
this pull request
Feb 28, 2019
This reverts commit e5395ea.
stephenplusplus
added a commit
that referenced
this pull request
Feb 28, 2019
This reverts commit e5395ea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're seeing a bunch of seemingly random 404 errors in our CI system test job. I believe this is because we now have to 2 system-test jobs and our test prefix is not unique. I was going to use
uuidbut doing so puts us over the character limit.