-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: javadoc job (JDK 17) in ci.yaml (#1819) #1386
ci: javadoc job (JDK 17) in ci.yaml (#1819) #1386
Conversation
This also changes the JDK distribution from zulu to temurin https://github.com/actions/setup-java#eclipse-temurin Source-Link: googleapis/synthtool@ef9fe2e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:31c8276a1bfb43766597d32645721c029cb94571f1b8d996cb2c290744fe52f9
Errors : https://github.com/googleapis/java-logging/actions/runs/5393565667/jobs/9793484162?pr=1386
@losalex Would you fix the javadoc failure on JDK 17? If it's too much or you're busy, I can take care of them. (warnings are just warnings. Focus on errors) |
Echanged messages. I'll take care of this. |
The javadoc was complaining about the missing type parameter in the
Supplying However, the class is generated by gapic-generator-java and https://github.com/googleapis/java-logging/blob/a3aa2ee2d8588ef2c9c265cb89a41ee68a5b0897/owlbot.py has the following replace rule:
Maybe we remove the |
I think owlbot.py should have this formatting below that includes method parameters, rather than existing "()".
|
The owlbot.py fix won't take effect until this pull request is merged and #1353 is regenerated. This pull request does not fix the javadoc job. |
This also changes the JDK distribution from zulu to temurin
https://github.com/actions/setup-java#eclipse-temurin
Source-Link: googleapis/synthtool@ef9fe2e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:31c8276a1bfb43766597d32645721c029cb94571f1b8d996cb2c290744fe52f9