feat: [AnalyticsAdmin] add RunAccessReport method (with bindings for account and property resources) to the Admin API v1beta
#5985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gcf-owl-bot[bot]](https://github.com/avatars/in/99011?s=60&v=4){kind=small}
…ple: /v1alpha/accounts/1234567:runAccessReport) feat: add `GetEnhancedMeasurementSettings`, `UpdateEnhancedMeasurementSettings` methods to the Admin API v1alpha feat: add `CreateConnectedSiteTag`, `DeleteConnectedSiteTag`, `ListConnectedSiteTags` methods to the Admin API v1alpha feat: add `EnhancedMeasurementSettings`, `ConnectedSiteTag` resource types to the Admin API v1alpha feat: add `GetEnhancedMeasurementSettingsRequest`, `UpdateEnhancedMeasurementSettingsRequest`,`CreateConnectedSiteTagRequest`, `CreateConnectedSiteTagResponse`, `DeleteConnectedSiteTagRequest`, `ListConnectedSiteTagsRequest`, `ListConnectedSiteTagsResponse` feat: add `ENHANCED_MEASUREMENT_SETTINGS` option to the `ChangeHistoryResourceType` enum feat: add `enhanced_measurement_settings` option to the `ChangeHistoryResource.resource` oneof field feat: add `intraday_export_enabled` field to the `BigQueryLink` resource PiperOrigin-RevId: 518088512 Source-Link: googleapis/googleapis@061a9fb Source-Link: googleapis/googleapis-gen@c64b9cd Copy-Tag: eyJwIjoiQW5hbHl0aWNzQWRtaW4vLk93bEJvdC55YW1sIiwiaCI6ImM2NGI5Y2QzODA3M2IyMjAyY2U2ZWIwN2Q1OGM2YThjNTgxZmNlMmMifQ==
|
Here is the summary of changes. You are about to add 6 region tags.
This comment is generated by snippet-bot.
|
trusted-contributions-gcf
bot
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
trusted-contributions-gcf
bot
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
bshaffer
reviewed
Mar 22, 2023
There was a problem hiding this comment.
The breaking changes are as follows:
Error: Method Google\Analytics\Admin\V1alpha\EnhancedMeasurementSettings#getPageViewsEnabled() was removed
Error: Method Google\Analytics\Admin\V1alpha\EnhancedMeasurementSettings#setPageViewsEnabled() was removed
Error: Method Google\Analytics\Admin\V1alpha\EnhancedMeasurementSettings#getPageLoadsEnabled() was removed
Error: Method Google\Analytics\Admin\V1alpha\EnhancedMeasurementSettings#setPageLoadsEnabled() was removed
I looked at the Piper RevID, and could not find any evidence of these fields being removed (and nothing is marked as breaking in the conventional commits). I'll do a little more digging to find out why this happened.
In the meantime, we can take this breaking change because 1. we are pre-GA (v0.10.0) and the API is still in alpha.
…perty resources) to the Admin API v1beta feat: add `AccessDimension`, `AccessMetric`, `AccessDateRange`, `AccessFilterExpression`, `AccessFilterExpressionList`, `AccessFilter`, `AccessStringFilter`, `AccessInListFilter`, `AccessNumericFilter`, `AccessBetweenFilter`, `NumericValue`, `AccessOrderBy`, `AccessDimensionHeader`, `AccessMetricHeader`, `AccessRow`, `AccessDimensionValue`, `AccessMetricValue`, `AccessQuota`, `AccessQuotaStatus` types to the Admin API v1beta PiperOrigin-RevId: 519058583 Source-Link: googleapis/googleapis@71bd02e Source-Link: googleapis/googleapis-gen@5d4f0f6 Copy-Tag: eyJwIjoiQW5hbHl0aWNzQWRtaW4vLk93bEJvdC55YW1sIiwiaCI6IjVkNGYwZjZiNDU5MjNkNjJjN2VlYzY1NmJhY2MzZjA2MzNlMDExZjcifQ==
gcf-owl-bot
bot
changed the title
RunAccessReport method (example: /v1alpha/accounts/1234567:runAccessReport)RunAccessReport method (with bindings for account and property resources) to the Admin API v1beta
trusted-contributions-gcf
bot
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
trusted-contributions-gcf
bot
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
bshaffer
approved these changes
Mar 24, 2023
There was a problem hiding this comment.
Okay I found it. In this. commit, two years ago, the EnhancedMeasurementSettings class was removed, but as we don't track removals, the file stayed in the repo. Now, in this commit, which is the one that updated this PR, the class was added back, but without the two fields being complained about by our BC-checker.
trusted-contributions-gcf
bot
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add
AccessDimension,AccessMetric,AccessDateRange,AccessFilterExpression,AccessFilterExpressionList,AccessFilter,AccessStringFilter,AccessInListFilter,AccessNumericFilter,AccessBetweenFilter,NumericValue,AccessOrderBy,AccessDimensionHeader,AccessMetricHeader,AccessRow,AccessDimensionValue,AccessMetricValue,AccessQuota,AccessQuotaStatustypes to the Admin API v1betaPiperOrigin-RevId: 519058583
Source-Link: googleapis/googleapis@71bd02e
Source-Link: https://github.com/googleapis/googleapis-gen/commit/5d4f0f6b45923d62c7eec656bacc3f0633e011f7
Copy-Tag: eyJwIjoiQW5hbHl0aWNzQWRtaW4vLk93bEJvdC55YW1sIiwiaCI6IjVkNGYwZjZiNDU5MjNkNjJjN2VlYzY1NmJhY2MzZjA2MzNlMDExZjcifQ==
BEGIN_NESTED_COMMIT
feat: [AnalyticsAdmin] add account-level binding for the
RunAccessReportmethod (example: /v1alpha/accounts/1234567:runAccessReport)feat: add
GetEnhancedMeasurementSettings,UpdateEnhancedMeasurementSettingsmethods to the Admin API v1alphafeat: add
CreateConnectedSiteTag,DeleteConnectedSiteTag,ListConnectedSiteTagsmethods to the Admin API v1alphafeat: add
EnhancedMeasurementSettings,ConnectedSiteTagresource types to the Admin API v1alphafeat: add
GetEnhancedMeasurementSettingsRequest,UpdateEnhancedMeasurementSettingsRequest,CreateConnectedSiteTagRequest,CreateConnectedSiteTagResponse,DeleteConnectedSiteTagRequest,ListConnectedSiteTagsRequest,ListConnectedSiteTagsResponsefeat: add
ENHANCED_MEASUREMENT_SETTINGSoption to theChangeHistoryResourceTypeenumfeat: add
enhanced_measurement_settingsoption to theChangeHistoryResource.resourceoneof fieldfeat: add
intraday_export_enabledfield to theBigQueryLinkresourcePiperOrigin-RevId: 518088512
Source-Link: googleapis/googleapis@061a9fb
Source-Link: https://github.com/googleapis/googleapis-gen/commit/c64b9cd38073b2202ce6eb07d58c6a8c581fce2c
Copy-Tag: eyJwIjoiQW5hbHl0aWNzQWRtaW4vLk93bEJvdC55YW1sIiwiaCI6ImM2NGI5Y2QzODA3M2IyMjAyY2U2ZWIwN2Q1OGM2YThjNTgxZmNlMmMifQ==
END_NESTED_COMMIT
BREAKING_CHANGE_REASON=This is an alpha API in a preview state, but also the class that changed hasn't been functional for two years