Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Spanner): Support FGAC #5642

Merged
merged 10 commits into from
Dec 14, 2022
Merged

feat(Spanner): Support FGAC #5642

merged 10 commits into from
Dec 14, 2022

Conversation

ajupazhamayil
Copy link
Contributor

@ajupazhamayil ajupazhamayil commented Nov 22, 2022

This PR add the FGAC support for PHP Spanner library.

The FGAC integration tests are skipped in the emulator since it has not yet implemented the FGAC support.

Other languages also skips the same. Ref: https://github.com/googleapis/google-cloud-ruby/pull/19067/files#diff-3bf69404604fe1c87333533412f6e24d5867aab51a726e98843ebd63cd39b3a5R28

@ajupazhamayil ajupazhamayil requested review from a team as code owners November 22, 2022 09:59
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Nov 22, 2022
@ajupazhamayil ajupazhamayil self-assigned this Nov 22, 2022
@ajupazhamayil ajupazhamayil marked this pull request as draft November 22, 2022 10:01
@ajupazhamayil ajupazhamayil force-pushed the FGAC_Spanner branch 6 times, most recently from 79098dc to 50ea8d3 Compare November 23, 2022 10:17
@ajupazhamayil ajupazhamayil changed the title feat(Spanner): Implement FGAC feat(Spanner): Supoort FGAC Nov 23, 2022
@ajupazhamayil ajupazhamayil marked this pull request as ready for review November 23, 2022 12:19
Copy link
Contributor

@vishwarajanand vishwarajanand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls fix the formatting, docblocks and test changes requested.

@ajupazhamayil ajupazhamayil added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 7, 2022
@vishwarajanand
Copy link
Contributor

vishwarajanand commented Dec 7, 2022

In my local env, php8.1, for pre-existing tests parsing V1/Session object fails at

$args['session'] = $this->serializer->decodeMessage(new Session, $session);
when creator_role is null. Do you think we should add array_filter over here:
'session' => [
'labels' => $this->pluck('labels', $options, false) ?: [],
'creator_role' => $this->pluck('creator_role', $options, false) ?: null
]

composer.json Outdated Show resolved Hide resolved
@vishwarajanand
Copy link
Contributor

Changes looks good to me now, thanks for diligently resolve all comments.
Only 2 changes pending: array_filter styling and rebase with main.

Copy link
Contributor

@vishwarajanand vishwarajanand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vishwarajanand vishwarajanand merged commit 0f25677 into main Dec 14, 2022
@vishwarajanand vishwarajanand deleted the FGAC_Spanner branch December 14, 2022 06:01
Spanner/src/Session/CacheSessionPool.php Show resolved Hide resolved
Spanner/src/Database.php Show resolved Hide resolved
Spanner/src/Batch/BatchClient.php Show resolved Hide resolved
Spanner/src/SpannerClient.php Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Spanner API. kokoro:force-run Add this label to force Kokoro to re-run the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants