Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement NaturalLanguage changes #241

Merged
merged 3 commits into from
Nov 14, 2016
Merged

Implement NaturalLanguage changes #241

merged 3 commits into from
Nov 14, 2016

Conversation

jdpedrie
Copy link
Contributor

@jdpedrie jdpedrie commented Nov 11, 2016

Please hold this until 11/15.

@jdpedrie jdpedrie added do not merge Indicates a pull request not ready for merge, due to either quality or timing. natural language labels Nov 11, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 11, 2016
Copy link
Contributor

@michaelbausor michaelbausor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 1 question. Please let others take a look also.

$this->formatRequest($content, $options)
);

return new Annotation($syntaxResponse + ['entities' => []]);

This comment was marked as spam.

This comment was marked as spam.

@jdpedrie jdpedrie merged commit e7d59f9 into googleapis:master Nov 14, 2016
@jdpedrie jdpedrie mentioned this pull request Nov 14, 2016
@jdpedrie jdpedrie deleted the nl-update branch June 9, 2017 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants