fix: removed abandoned package from composer

[vishwarajanand]

Wikimedia/avro package is abandoned and users are getting deprecating notice on composer update from root.
Per the deprecation flag on packagist website, upgrading to rg/avro-php to a latest version that supports PHP>=5.6.

Links to packages:
https://packagist.org/packages/wikimedia/avro

https://packagist.org/packages/rg/avro-php#1.8.0

Internal bug: b/218995638

[bshaffer]

Thanks for catching this. Do you know where this package is used? That way we can make sure the new package works (in case test coverage has gaps)

[saranshdhingra]

I think Avro records are used in PubSub. Can we verify the system tests are working when we replace this?

[dwsupplee]

Thanks for this @vishwarajanand. I tested this out and got the following error: PHP Fatal error: Array and string offset access syntax with curly braces is no longer supported in /Users/dsupplee/dev/google-cloud-php/vendor/rg/avro-php/lib/avro/protocol.php on line 57.

We could use a version of the avro library that supports 7.4+ and skip this test if it is run on a system that is lower than that req.

[vishwarajanand]

Hi reviewers, thanks for looking into this. Per my understanding, AVRO is used in BigQuery/PubSub codebase mostly as an identifier to denote the AVRO type records. There are a couple of tests who pass AVRO record type and parse the results to asset on values. Ex: Schema::Type.
Sorry, I didnt run system tests before and now I am also fixing a test failure: BigQuery/tests/System/LoadDataAndQueryTest

[vishwarajanand]

@dwsupplee , great suggestion. ❤️‍🔥
I got the deprecation notice too and I now used double pipe versioning in composer.json because it doesn't occur in newer package versions. Unlike before, I had to add the dev dependency in PubSub's composer too, to get this working.