Skip to content

Commit

Permalink
feat: [Spanner] add Session creator role (#5318)
Browse files Browse the repository at this point in the history
* feat: add Session creator role
docs: clarify transaction semantics

PiperOrigin-RevId: 452634948

Source-Link: googleapis/googleapis@df51ec8

Source-Link: googleapis/googleapis-gen@25426f6
Copy-Tag: eyJwIjoiU3Bhbm5lci8uT3dsQm90LnlhbWwiLCJoIjoiMjU0MjZmNmZkMTdjNTIyOWUxN2ExZjM3ODU4Y2I2YzE3MzhmMGNhZCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
  • Loading branch information
gcf-owl-bot[bot] and gcf-owl-bot[bot] committed Jun 7, 2022
1 parent 65913d0 commit fb87e51
Show file tree
Hide file tree
Showing 6 changed files with 143 additions and 40 deletions.
Binary file modified Spanner/metadata/V1/ResultSet.php
Binary file not shown.
Binary file modified Spanner/metadata/V1/Spanner.php
Binary file not shown.
34 changes: 34 additions & 0 deletions Spanner/src/V1/Session.php

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

73 changes: 53 additions & 20 deletions Spanner/src/V1/TransactionOptions.php

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

72 changes: 52 additions & 20 deletions Spanner/src/V1/resources/spanner_rest_client_config.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,21 @@
return [
'interfaces' => [
'google.longrunning.Operations' => [
'GetOperation' => [
'method' => 'get',
'uriTemplate' => '/v1/{name=projects/*/instances/*/databases/*/operations/*}',
'CancelOperation' => [
'method' => 'post',
'uriTemplate' => '/v1/{name=projects/*/instances/*/databases/*/operations/*}:cancel',
'additionalBindings' => [
[
'method' => 'get',
'uriTemplate' => '/v1/{name=projects/*/instances/*/operations/*}',
'method' => 'post',
'uriTemplate' => '/v1/{name=projects/*/instances/*/operations/*}:cancel',
],
[
'method' => 'post',
'uriTemplate' => '/v1/{name=projects/*/instances/*/backups/*/operations/*}:cancel',
],
[
'method' => 'post',
'uriTemplate' => '/v1/{name=projects/*/instanceConfigs/*/operations/*}:cancel',
],
],
'placeholders' => [
Expand All @@ -20,13 +28,21 @@
],
],
],
'ListOperations' => [
'method' => 'get',
'uriTemplate' => '/v1/{name=projects/*/instances/*/databases/*/operations}',
'DeleteOperation' => [
'method' => 'delete',
'uriTemplate' => '/v1/{name=projects/*/instances/*/databases/*/operations/*}',
'additionalBindings' => [
[
'method' => 'get',
'uriTemplate' => '/v1/{name=projects/*/instances/*/operations}',
'method' => 'delete',
'uriTemplate' => '/v1/{name=projects/*/instances/*/operations/*}',
],
[
'method' => 'delete',
'uriTemplate' => '/v1/{name=projects/*/instances/*/backups/*/operations/*}',
],
[
'method' => 'delete',
'uriTemplate' => '/v1/{name=projects/*/instanceConfigs/*/operations/*}',
],
],
'placeholders' => [
Expand All @@ -37,13 +53,21 @@
],
],
],
'CancelOperation' => [
'method' => 'post',
'uriTemplate' => '/v1/{name=projects/*/instances/*/databases/*/operations/*}:cancel',
'GetOperation' => [
'method' => 'get',
'uriTemplate' => '/v1/{name=projects/*/instances/*/databases/*/operations/*}',
'additionalBindings' => [
[
'method' => 'post',
'uriTemplate' => '/v1/{name=projects/*/instances/*/operations/*}:cancel',
'method' => 'get',
'uriTemplate' => '/v1/{name=projects/*/instances/*/operations/*}',
],
[
'method' => 'get',
'uriTemplate' => '/v1/{name=projects/*/instances/*/backups/*/operations/*}',
],
[
'method' => 'get',
'uriTemplate' => '/v1/{name=projects/*/instanceConfigs/*/operations/*}',
],
],
'placeholders' => [
Expand All @@ -54,13 +78,21 @@
],
],
],
'DeleteOperation' => [
'method' => 'delete',
'uriTemplate' => '/v1/{name=projects/*/instances/*/databases/*/operations/*}',
'ListOperations' => [
'method' => 'get',
'uriTemplate' => '/v1/{name=projects/*/instances/*/databases/*/operations}',
'additionalBindings' => [
[
'method' => 'delete',
'uriTemplate' => '/v1/{name=projects/*/instances/*/operations/*}',
'method' => 'get',
'uriTemplate' => '/v1/{name=projects/*/instances/*/operations}',
],
[
'method' => 'get',
'uriTemplate' => '/v1/{name=projects/*/instances/*/backups/*/operations}',
],
[
'method' => 'get',
'uriTemplate' => '/v1/{name=projects/*/instanceConfigs/*/operations}',
],
],
'placeholders' => [
Expand Down
4 changes: 4 additions & 0 deletions Spanner/tests/Unit/V1/SpannerClientTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -291,8 +291,10 @@ public function createSessionTest()
$this->assertTrue($transport->isExhausted());
// Mock response
$name = 'name3373707';
$creatorRole = 'creatorRole-1605962583';
$expectedResponse = new Session();
$expectedResponse->setName($name);
$expectedResponse->setCreatorRole($creatorRole);
$transport->addResponse($expectedResponse);
// Mock request
$formattedDatabase = $client->databaseName('[PROJECT]', '[INSTANCE]', '[DATABASE]');
Expand Down Expand Up @@ -646,8 +648,10 @@ public function getSessionTest()
$this->assertTrue($transport->isExhausted());
// Mock response
$name2 = 'name2-1052831874';
$creatorRole = 'creatorRole-1605962583';
$expectedResponse = new Session();
$expectedResponse->setName($name2);
$expectedResponse->setCreatorRole($creatorRole);
$transport->addResponse($expectedResponse);
// Mock request
$formattedName = $client->sessionName('[PROJECT]', '[INSTANCE]', '[DATABASE]', '[SESSION]');
Expand Down

0 comments on commit fb87e51

Please sign in to comment.