chore: add presubmit and continuous kokoro tests (#5229)

* chore: add kokoro configs for running tests on PHP 7.4 and 8.0

* update PHP version for docs

* use php80 for continuous tests

* update kokoro to ues php 8 for docs gen

* update cs library and fix cs

* hopefully fix tests

* Revert "hopefully fix tests"

This reverts commit 60fe138.

* fix tests for PHP 7.4

* Update docs.yml

* remove 8.0

.github/workflows/docs.yml

@@ -21,7 +21,7 @@ jobs:
         - name: Setup PHP
           uses: shivammathur/setup-php@v2
           with:
-            php-version: '7.3'
+            php-version: '7.4'
             ini-values: memory_limit=2048M
         - name: Install Dependencies
           uses: nick-invision/retry@v1

.kokoro/continuous/php72.cfg → .kokoro/continuous/php74.cfg

@@ -15,7 +15,7 @@ env_vars: {
 # Configure the docker image for kokoro-trampoline.
 env_vars: {
     key: "TRAMPOLINE_IMAGE"
-    value: "gcr.io/cloud-devrel-kokoro-resources/php72"
+    value: "gcr.io/cloud-devrel-kokoro-resources/php74"
 }
 
 # key files from keystore

.kokoro/presubmit/php74.cfg

@@ -0,0 +1,7 @@
+# Format: //devtools/kokoro/config/proto/build.proto
+
+# Configure the docker image for kokoro-trampoline.
+env_vars: {
+    key: "TRAMPOLINE_IMAGE"
+    value: "gcr.io/cloud-devrel-kokoro-resources/php74"
+}

.kokoro/presubmit/run-tests.sh

@@ -45,8 +45,8 @@ echo "Running Snippet Test Suite"
 vendor/bin/phpunit -c phpunit${PHPUNIT_SUFFIX}.xml.dist --verbose --log-junit \
                    ${SNIPPETS_LOG_FILENAME}
 
-# Run docs gen on PHP 7.3 only
-if [ "7.3" == ${PHP_VERSION:0:3} ]; then
+# Run docs gen on PHP 7.4 only
+if [ "7.4" == ${PHP_VERSION:0:3} ]; then
     echo "Running Doc Generator"
 
     # Require phpdocumentor:4 for docs generation

BigQuery/tests/Unit/QueryResultsTest.php

@@ -36,6 +36,7 @@ class QueryResultsTest extends TestCase
     public $jobId = 'myJobId';
     public $queryData = [
         'jobComplete' => true,
+        'jobReference' => ['location' => 123],
         'rows' => [
             ['f' => [['v' => 'Alton'], ['v' => 1]]]
         ],
@@ -203,7 +204,7 @@ public function testReloadsInfo()
 
     public function testGetsIdentity()
     {
-        $queryResults = $this->getQueryResults($this->connection);
+        $queryResults = $this->getQueryResults($this->connection, $this->queryData);
 
         $this->assertEquals($this->jobId, $queryResults->identity()['jobId']);
         $this->assertEquals($this->projectId, $queryResults->identity()['projectId']);

Core/src/Batch/BatchTrait.php

@@ -130,7 +130,7 @@ public function send(array $items)
      *
      * @return array
      */
-    protected abstract function getCallback();
+    abstract protected function getCallback();
 
     /**
      * @param array $options [optional] {

Firestore/tests/Unit/FirestoreSessionHandlerTest.php

@@ -56,7 +56,8 @@ public function setUp()
     public function testOpen()
     {
         $this->connection->beginTransaction(['database' => $this->dbName()])
-            ->shouldBeCalledTimes(1);
+            ->shouldBeCalledTimes(1)
+            ->willReturn(['transaction' => null]);
         $firestoreSessionHandler = new FirestoreSessionHandler(
             $this->connection->reveal(),
             $this->valueMapper->reveal(),
@@ -90,6 +91,9 @@ public function testOpenWithException()
      */
     public function testReadNotAllowed()
     {
+        $this->connection->beginTransaction(['database' => $this->dbName()])
+            ->shouldBeCalledTimes(1)
+            ->willReturn(['transaction' => null]);
         $firestoreSessionHandler = new FirestoreSessionHandler(
             $this->connection->reveal(),
             $this->valueMapper->reveal(),
@@ -124,7 +128,8 @@ public function testReadNothing()
             ->shouldBeCalledTimes(1)
             ->willReturn(null);
         $this->connection->beginTransaction(['database' => $this->dbName()])
-            ->shouldBeCalledTimes(1);
+            ->shouldBeCalledTimes(1)
+            ->willReturn(['transaction' => null]);
         $this->connection->batchGetDocuments([
             'database' => $this->dbName(),
             'documents' => [$this->documentName()],
@@ -150,7 +155,8 @@ public function testReadNothing()
     public function testReadWithException()
     {
         $this->connection->beginTransaction(['database' => $this->dbName()])
-            ->shouldBeCalledTimes(1);
+            ->shouldBeCalledTimes(1)
+            ->willReturn(['transaction' => null]);
         $this->connection->batchGetDocuments([
             'database' => $this->dbName(),
             'documents' => [$this->documentName()],
@@ -186,7 +192,8 @@ public function testReadEntity()
             ->shouldBeCalledTimes(1)
             ->willReturn(['data' => 'sessiondata']);
         $this->connection->beginTransaction(['database' => $this->dbName()])
-            ->shouldBeCalledTimes(1);
+            ->shouldBeCalledTimes(1)
+            ->willReturn(['transaction' => null]);
         $this->connection->batchGetDocuments([
             'database' => $this->dbName(),
             'documents' => [$this->documentName()],
@@ -217,7 +224,8 @@ public function testWrite()
                 return ['data' => ['stringValue' => 'sessiondata']];
             });
         $this->connection->beginTransaction(['database' => $this->dbName()])
-            ->shouldBeCalledTimes(1);
+            ->shouldBeCalledTimes(1)
+            ->willReturn(['transaction' => null]);
         $this->connection->commit([
             'database' => $this->dbName(),
             'writes' => [

Spanner/tests/Snippet/Batch/PartitionSharedSnippetTestTrait.php

@@ -26,7 +26,7 @@ trait PartitionSharedSnippetTestTrait
     private $token = 'token';
     private $options = ['hello' => 'world'];
 
-    public abstract function setUp();
+    abstract public function setUp();
 
     /**
      * @dataProvider provideSerializeSnippetIndex

composer.json

@@ -57,7 +57,7 @@
     },
     "require-dev": {
         "phpunit/phpunit": "^4.8|^5.0",
-        "squizlabs/php_codesniffer": "2.*",
+        "squizlabs/php_codesniffer": "3.*",
         "phpdocumentor/reflection": "^3.0",
         "symfony/console": "^3.0",
         "erusev/parsedown": "^1.6",