Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigQuery: Fix timestamp parsing regression #4510

Merged
merged 2 commits into from
Feb 20, 2019

Conversation

pmakani
Copy link

@pmakani pmakani commented Feb 15, 2019

Fixes #4500

@pmakani pmakani requested a review from sduskis February 15, 2019 21:23
@pmakani pmakani requested a review from a team as a code owner February 15, 2019 21:23
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 15, 2019
@ajaaym ajaaym changed the title Fixes BigQuery timestamp parsing. BigQuery: Fix timestamp parsing regression Feb 15, 2019
@codecov
Copy link

codecov bot commented Feb 15, 2019

Codecov Report

Merging #4510 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4510      +/-   ##
============================================
- Coverage     49.16%   49.14%   -0.02%     
+ Complexity    21929    21927       -2     
============================================
  Files          2077     2078       +1     
  Lines        207074   207184     +110     
  Branches      24097    24106       +9     
============================================
+ Hits         101801   101815      +14     
- Misses        97100    97196      +96     
  Partials       8173     8173
Impacted Files Coverage Δ Complexity Δ
...com/google/cloud/bigquery/QueryParameterValue.java 68.84% <100%> (+3.51%) 43 <1> (ø) ⬇️
...loud/bigtable/data/v2/internal/RequestContext.java 33.33% <0%> (-66.67%) 2% <0%> (ø)
.../bigtable/admin/v2/BigtableTableAdminSettings.java 78.37% <0%> (-21.63%) 6% <0%> (ø)
...gtable/admin/v2/BigtableInstanceAdminSettings.java 82.14% <0%> (-17.86%) 5% <0%> (ø)
...ble/data/v2/stub/EnhancedBigtableStubSettings.java 93.19% <0%> (-5.37%) 15% <0%> (-2%)
...gle/cloud/bigtable/data/v2/BigtableDataClient.java 84.31% <0%> (-5.27%) 32% <0%> (ø)
...e/cloud/bigtable/data/v2/BigtableDataSettings.java 31.7% <0%> (-3.43%) 3% <0%> (ø)
...le/cloud/bigtable/data/v2/models/InstanceName.java 0% <0%> (ø) 0% <0%> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 344fdac...2387727. Read the comment docs.

@@ -60,6 +62,21 @@
@AutoValue
public abstract class QueryParameterValue implements Serializable {

private static final DateTimeFormatter timestampValidator =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we replace timestampFormatter with your configuration for timestampValidator?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can't be done with single formatter.

@sduskis sduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 19, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 19, 2019
@sduskis sduskis added the api: bigquery Issues related to the BigQuery API. label Feb 20, 2019
@sduskis sduskis merged commit 7a6aa23 into googleapis:master Feb 20, 2019
@pmakani pmakani deleted the api-bigquery-bug-4500 branch February 25, 2019 12:36
@pmakani pmakani restored the api-bigquery-bug-4500 branch February 28, 2019 17:11
@pmakani pmakani deleted the api-bigquery-bug-4500 branch March 1, 2019 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants