Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bigtable: expose credential provider as a toplevel setting #4508

Merged
merged 5 commits into from
Feb 20, 2019

Conversation

igorbernstein2
Copy link

Extracted from #4498

@igorbernstein2 igorbernstein2 added the api: bigtable Issues related to the Bigtable API. label Feb 15, 2019
@igorbernstein2 igorbernstein2 requested a review from a team as a code owner February 15, 2019 19:30
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 15, 2019
@codecov
Copy link

codecov bot commented Feb 15, 2019

Codecov Report

Merging #4508 into master will decrease coverage by 0.3%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4508      +/-   ##
============================================
- Coverage     48.83%   48.53%   -0.31%     
+ Complexity    21932    20742    -1190     
============================================
  Files          2077     2077              
  Lines        207078   203046    -4032     
  Branches      23407    23294     -113     
============================================
- Hits         101119    98539    -2580     
+ Misses        97120    96431     -689     
+ Partials       8839     8076     -763
Impacted Files Coverage Δ Complexity Δ
...gtable/admin/v2/BigtableInstanceAdminSettings.java 100% <100%> (ø) 6 <1> (+1) ⬆️
.../bigtable/admin/v2/BigtableTableAdminSettings.java 71.73% <100%> (+2.69%) 7 <1> (+1) ⬆️
...m/google/cloud/vision/v1/ImageAnnotatorClient.java 47.05% <0%> (-2.95%) 9% <0%> (-2%)
...e/cloud/vision/v1p3beta1/ImageAnnotatorClient.java 47.05% <0%> (-2.95%) 9% <0%> (-2%)
...e/cloud/vision/v1p2beta1/ImageAnnotatorClient.java 47.05% <0%> (-2.95%) 9% <0%> (-2%)
.../java/com/google/cloud/speech/v1/SpeechClient.java 48.57% <0%> (-2.78%) 10% <0%> (-2%)
...om/google/cloud/speech/v1p1beta1/SpeechClient.java 48.57% <0%> (-2.78%) 10% <0%> (-2%)
...ogle/cloud/texttospeech/v1/TextToSpeechClient.java 55.88% <0%> (-2.46%) 9% <0%> (-2%)
...cloud/texttospeech/v1beta1/TextToSpeechClient.java 55.88% <0%> (-2.46%) 9% <0%> (-2%)
...gle/cloud/storage/testing/RemoteStorageHelper.java 55.37% <0%> (-2.36%) 8% <0%> (ø)
... and 467 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6cf8d3...df0874b. Read the comment docs.

# Conflicts:
#	google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableInstanceAdminSettings.java
#	google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminSettings.java
@igorbernstein2 igorbernstein2 merged commit 9902978 into googleapis:master Feb 20, 2019
@igorbernstein2 igorbernstein2 deleted the settings-4 branch February 20, 2019 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants