Updating datastore write-related functions to v1beta3 #173

ajkannan · 2015-09-23T02:03:54Z

This PR:
-- Updates entities & mutations to use v1beta3. This includes tweaks to add methods to maintain a clear order.
-- Removes BatchOption and TransactionOption classes (since isolation level and force writes have been deprecated)
-- Modifies spi files & LocalGcdHelper.java to use v1beta3 (needed to run DatastoreTests)

gcloud-java-datastore/src/main/java/com/google/gcloud/datastore/BaseDatastoreBatchWriter.java

@@ -185,6 +184,10 @@ protected String name() {
    return toDelete;
  }

+  protected int numAutoAllocatedIds() {


aozarov · 2015-09-26T18:51:30Z

@ajkannan good job. done reviewing. please fix mentioned issue and I think then it is ready for merge.

gcloud-java-datastore/src/test/java/com/google/gcloud/datastore/LocalGcdHelper.java

@@ -309,7 +309,7 @@ public static void main(String... args) throws IOException, InterruptedException
  public static boolean isActive(String projectId) {
    try {
      StringBuilder urlBuilder = new StringBuilder("http://localhost:").append(PORT);
-      urlBuilder.append("/datastore/v1beta2/datasets/").append(projectId).append("/lookup");
+      urlBuilder.append("/datastore/v1beta3/datasets/").append(projectId).append(":lookup");


googlebot · 2015-10-01T01:33:58Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

googlebot · 2015-10-01T01:42:24Z

CLAs look good, thanks!

ajkannan · 2015-10-05T15:05:32Z

@aozarov The latest round of comments (regarding DefaultDatastoreRpc.java) have been incorporated.

…empty

… URL scheme

aozarov · 2015-10-05T16:55:51Z

LGTM.

Updating datastore write-related functions to v1beta3

…ws (googleapis#173) This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/129bf4ce-2255-4b88-83a1-1b40d560e3d3/targets Source-Link: googleapis/synthtool@8b65daa

) * chore: update dependencies for regapic * add more dependencies and trigger comment * update goldens * fix indentation * remove duplicate gax-httpjson dependency * remove duplicated dependencies Source-Link: googleapis/synthtool@fa54eb2 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:1ec28a46062b19135b11178ceee60231e5f5a92dab454e23ae0aab72cd875906

…plugin to v3 (#173) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.maven.plugins:maven-deploy-plugin](https://maven.apache.org/plugins/) | `2.8.2` -> `3.0.0` | [![age](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-deploy-plugin/3.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-deploy-plugin/3.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-deploy-plugin/3.0.0/compatibility-slim/2.8.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-deploy-plugin/3.0.0/confidence-slim/2.8.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-storage-transfer).

🤖 I have created a release *beep* *boop* --- ## [1.2.6](https://togithub.com/googleapis/java-ids/compare/v1.2.5...v1.2.6) (2022-10-03) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#172](https://togithub.com/googleapis/java-ids/issues/172)) ([e3dd2dd](https://togithub.com/googleapis/java-ids/commit/e3dd2dd347b50f19c2b16cd916f4baf82349ee95)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ## [0.6.2](https://togithub.com/googleapis/java-bigquerymigration/compare/v0.6.1...v0.6.2) (2022-10-04) ### Bug Fixes * update protobuf to v3.21.7 ([aa8719d](https://togithub.com/googleapis/java-bigquerymigration/commit/aa8719df925fee0925a68f31e3f1a58c404c1752)) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#172](https://togithub.com/googleapis/java-bigquerymigration/issues/172)) ([e561188](https://togithub.com/googleapis/java-bigquerymigration/commit/e5611888cbc936e1ce23b90fff79681deb553fdf)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ## [1.3.5](https://togithub.com/googleapis/java-vmmigration/compare/v1.3.4...v1.3.5) (2022-10-05) ### Bug Fixes * update protobuf to v3.21.7 ([5ee1266](https://togithub.com/googleapis/java-vmmigration/commit/5ee1266ba4038f8e0190d6dd5e1d2ef200afb6fc)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

Updates to write-related code for datastore v1beta3 update

e078469

ajkannan added the api: datastore Issues related to the Datastore API. label Sep 23, 2015

ajkannan assigned aozarov Sep 23, 2015

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 23, 2015

aozarov reviewed Sep 26, 2015
View reviewed changes

gcloud-java-datastore/src/main/java/com/google/gcloud/datastore/BaseDatastoreBatchWriter.java

@@ -185,6 +184,10 @@ protected String name() {

return toDelete;

}

protected int numAutoAllocatedIds() {

This comment was marked as spam.

Sign in to view

pcostell reviewed Sep 28, 2015
View reviewed changes

ajkannan force-pushed the v1beta3-write-update branch from d3ecaa3 to 592e45e Compare September 28, 2015 23:34

cleanup v1beta3 changes and fix LocalGcdHelper bugs

959d67d

ajkannan force-pushed the v1beta3-write-update branch from 592e45e to 959d67d Compare September 28, 2015 23:38

googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Oct 1, 2015

ajkannan force-pushed the v1beta3-write-update branch from fe19b53 to d961040 Compare October 1, 2015 01:39

Fix handling of host in DatastoreOptions.java

9463c55

ajkannan force-pushed the v1beta3-write-update branch from d961040 to 9463c55 Compare October 1, 2015 01:42

googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Oct 1, 2015

ajkannan force-pushed the v1beta3-write-update branch from f238f87 to a72a0cb Compare October 5, 2015 16:02

Remove scheme from localhost and check if user-provided host is null/…

4d2fe25

…empty

ajkannan force-pushed the v1beta3-write-update branch from a72a0cb to 4d2fe25 Compare October 5, 2015 16:15

Fix version in LocalGcdHelper and check for null values when removing…

e0aaaba

… URL scheme

ajkannan added a commit that referenced this pull request Oct 5, 2015

Merge pull request #173 from ajkannan/v1beta3-write-update

843718a

Updating datastore write-related functions to v1beta3

ajkannan merged commit 843718a into googleapis:update-datastore Oct 5, 2015

ajkannan deleted the v1beta3-write-update branch October 5, 2015 16:57

theacodes unassigned aozarov Sep 28, 2018

github-actions bot pushed a commit that referenced this pull request Jun 21, 2022

chore: include generated samples dir (#173)

d2ebdba

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updating datastore write-related functions to v1beta3 #173

Updating datastore write-related functions to v1beta3 #173

ajkannan commented Sep 23, 2015

This comment was marked as spam.

aozarov commented Sep 26, 2015

This comment was marked as spam.

This comment was marked as spam.

googlebot commented Oct 1, 2015

googlebot commented Oct 1, 2015

ajkannan commented Oct 5, 2015

aozarov commented Oct 5, 2015

Updating datastore write-related functions to v1beta3 #173

Updating datastore write-related functions to v1beta3 #173

Conversation

ajkannan commented Sep 23, 2015

This comment was marked as spam.

aozarov commented Sep 26, 2015

This comment was marked as spam.

This comment was marked as spam.

googlebot commented Oct 1, 2015

googlebot commented Oct 1, 2015

ajkannan commented Oct 5, 2015

aozarov commented Oct 5, 2015