Fix PubSub Iterator pullAsync: add callback to PubSubRpc.pull #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
/cc @aozarov |
| @@ -89,6 +93,56 @@ protected ExecutorFactory executorFactory() { | |||
| } | |||
| } | |||
|
|
|||
| private static final class PullFutureImpl implements PullFuture { | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Looks good to me. I didn't look at the tests or the doc changes. I will let @lesv do that. |
|
Comment fixed. @lesv ready if you want to have al look. |
|
Comments look fine |
mziccard
added a commit
to mziccard/gcloud-java
that referenced
this pull request
Jun 27, 2016
github-actions bot
pushed a commit
that referenced
this pull request
Oct 10, 2022
…telligence to v2.2.13 (#1048) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-video-intelligence](https://togithub.com/googleapis/java-video-intelligence) | `2.2.12` -> `2.2.13` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-video-intelligence). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMjIuMyIsInVwZGF0ZWRJblZlciI6IjMyLjIyMi4zIn0=-->
](https://renovatebot.com){kind=link}
suztomo
pushed a commit
that referenced
this pull request
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows from the discussion in #1041 and fixes
Future<Iterator<ReceivedMessage>> pullAsync.PubSubRpc.pullchanges signature toPullFuture pull(String).PullFutureextendsFuture<PullResponse>and allows to register callbacks to the RPC's future so messages can be added to the ack deadline renewer as soon as pulled.