Update logging with latest generator and GAX. #1046

shinfan · 2016-06-08T18:09:06Z

...-java-logging/baseline/src/main/java/com/google/cloud/logging/spi/v2/ConfigServiceV2Api.java

@@ -222,10 +295,9 @@ public void close() throws IOException {
   *


coveralls · 2016-06-08T18:15:49Z

Coverage remained the same at 82.357% when pulling 8350603 on shinfan:logging-alpha into 1ea7a77 on GoogleCloudPlatform:logging-alpha.

...-java-logging/baseline/src/main/java/com/google/cloud/logging/spi/v2/ConfigServiceV2Api.java

+ * ConfigServiceV2Api configServiceV2Api = ConfigServiceV2Api.create(configServiceV2Settings);
+ * </code>
+ * </pre>
+ *


mziccard · 2016-06-08T18:49:19Z

We should also add gcloud-java-logging to the parent pom so that tests are triggered.

shinfan · 2016-06-08T19:48:15Z

I have updated the parent pom and addressed all the comments. PTAL.

coveralls · 2016-06-09T00:34:16Z

Coverage remained the same at 82.357% when pulling 2c9b46e on shinfan:logging-alpha into 1ea7a77 on GoogleCloudPlatform:logging-alpha.

gcloud-java-logging/.classpath

@@ -0,0 +1,32 @@
+<?xml version="1.0" encoding="UTF-8"?>


mziccard · 2016-06-09T10:41:09Z

I believe that this PR should also remove gax-related directories (see issue #939).

For what concerns LocalLoggingImpl and LocalLoggingHelper they should live in the com.google.cloud.logging.testing package rather than com.google.cloud.logging.spi.v2.testing. However LocalLoggingImpl seems a rather simple implementation which is missing several features (support for Config and Metrics sub-services, for instance). I am not sure that we should expose it to users in its current state. @aozarov thoughts?

Are there plans to make LocalLoggingImpl a more complete stub or are you waiting for the emulator (see issue #472)? Is there an ETA for the emulator? /cc @jgeewax

Also just let me remind that there are a bunch of logging-related issues that resulted from previous Arie's thorough reviews and that still need to be addressed. If you believe that some of them have already been fixed feel free to close them.

coveralls · 2016-06-09T21:59:58Z

Coverage remained the same at 82.357% when pulling 1fe17bb on shinfan:logging-alpha into 1ea7a77 on GoogleCloudPlatform:logging-alpha.

shinfan · 2016-06-09T22:04:44Z

PTAL

I have removed the gax related files and thanks for the reminders. For the LocalLoggingImpl I believe we are moving to a more scalable testing plan (e.g. emulator but I am sure about the ETA at this point)

Now this PR addressed the following issues:
#943, #771, #939

* Update logging with latest generator. * Update comments * Update grpc dependencies. * Update local logging implementation. * Remove gax related files and .classpath

…1.3 (googleapis#1046) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/googleapis/java-cloud-bom)) | `26.1.2` -> `26.1.3` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.3/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.3/compatibility-slim/26.1.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.3/confidence-slim/26.1.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-video-intelligence).

…1.4 (#1046) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/googleapis/java-cloud-bom)) | `26.1.3` -> `26.1.4` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.4/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.4/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.4/compatibility-slim/26.1.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.4/confidence-slim/26.1.3)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-dlp).

…s to v2.11.0 (#1046)

Update logging with latest generator.

8350603

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 8, 2016

shinfan changed the title ~~Update logging with latest generator.~~ Update logging with latest generator and GAX. Jun 8, 2016

michaelbausor reviewed Jun 8, 2016
View reviewed changes

mziccard reviewed Jun 8, 2016
View reviewed changes

shinfan force-pushed the logging-alpha branch from e603c71 to 19a0052 Compare June 8, 2016 20:35

Update comments

e824a28

shinfan force-pushed the logging-alpha branch from 19a0052 to e824a28 Compare June 8, 2016 20:56

shinfan added 2 commits June 8, 2016 17:16

Update grpc dependencies.

53c0f24

Update local logging implemenration.

2c9b46e

mziccard reviewed Jun 9, 2016
View reviewed changes

gcloud-java-logging/.classpath

@@ -0,0 +1,32 @@

<?xml version="1.0" encoding="UTF-8"?>

This comment was marked as spam.

Sign in to view

Remove gax related files and .classpath

1fe17bb

mziccard merged commit eb7f9b9 into googleapis:logging-alpha Jun 13, 2016

This was referenced Jun 13, 2016

Remove gax-related directories from logging-alpha branch #939

Closed

UnsupportedClassVersionError when testing gcloud-java-logging #943

Closed

Move field declarations at the top of the class in gcloud-java-logging #771

Closed

suztomo pushed a commit that referenced this pull request Feb 1, 2023

deps: update dependency com.google.api.grpc:proto-google-common-proto…

1ed7d11

…s to v2.11.0 (#1046)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update logging with latest generator and GAX. #1046

Update logging with latest generator and GAX. #1046

shinfan commented Jun 8, 2016 •

edited

Loading

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

coveralls commented Jun 8, 2016

This comment was marked as spam.

This comment was marked as spam.

mziccard commented Jun 8, 2016

shinfan commented Jun 8, 2016

coveralls commented Jun 9, 2016

This comment was marked as spam.

mziccard commented Jun 9, 2016

coveralls commented Jun 9, 2016

shinfan commented Jun 9, 2016 •

edited

Loading

		@@ -222,10 +295,9 @@ public void close() throws IOException {
		*

Update logging with latest generator and GAX. #1046

Update logging with latest generator and GAX. #1046

Conversation

shinfan commented Jun 8, 2016 • edited Loading

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

coveralls commented Jun 8, 2016

This comment was marked as spam.

This comment was marked as spam.

mziccard commented Jun 8, 2016

shinfan commented Jun 8, 2016

coveralls commented Jun 9, 2016

This comment was marked as spam.

mziccard commented Jun 9, 2016

coveralls commented Jun 9, 2016

shinfan commented Jun 9, 2016 • edited Loading

shinfan commented Jun 8, 2016 •

edited

Loading

shinfan commented Jun 9, 2016 •

edited

Loading