4107: Disconnect response after request

googleapis · Nov 30, 2018 · 2e73e08 · 2e73e08
1 parent a7703f2
commit 2e73e08
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/...ts/google-cloud-storage/src/main/java/com/google/cloud/storage/spi/v1/HttpStorageRpc.java b/...ts/google-cloud-storage/src/main/java/com/google/cloud/storage/spi/v1/HttpStorageRpc.java
@@ -681,14 +681,19 @@ public void write(String uploadId, byte[] toWrite, int toWriteOffset, long destO
       int code;
       String message;
       IOException exception = null;
+      HttpResponse response = null;
       try {
-        HttpResponse response = httpRequest.execute();
+        response = httpRequest.execute();
         code = response.getStatusCode();
         message = response.getStatusMessage();
       } catch (HttpResponseException ex) {
         exception = ex;
         code = ex.getStatusCode();
         message = ex.getStatusMessage();
+      } finally {
+        if (response != null ) {
+          response.disconnect();
+        }
       }
       if (!last && code != 308 || last && !(code == 200 || code == 201)) {
         if (exception != null) {

diff --git a/google-cloud-clients/pom.xml b/google-cloud-clients/pom.xml
@@ -155,7 +155,7 @@
     <github.global.server>github</github.global.server>
     <site.installationModule>google-cloud-clients</site.installationModule>
     <bom.version>0.72.0-alpha</bom.version><!-- {x-version-update:google-cloud-bom:current} -->
-    <api-client.version>1.27.0</api-client.version>
+    <api-client.version>1.27.1-SNAPSHOT</api-client.version>
     <gax.version>1.35.0</gax.version>
     <google.auth.version>0.12.0</google.auth.version>
     <grpc.version>1.16.1</grpc.version>