feat(storage): easier mocks with ObjectMetadata
#9899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recapitulates the changes to make `BucketMetadata` easier to mock. This change adds modifiers for all the fields in `ObjectMetadata` and removes the need for `internal::CommonMetadata<>`. Since `internal::CommonMetadata<>` is not needed, I deprecated the class, removed all references to the class or its header file, and refactor any useful code out of its header file.
product-auto-label
bot
added
the
api: storage
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov ReportBase: 94.19% // Head: 94.20% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #9899 +/- ##
========================================
Coverage 94.19% 94.20%
========================================
Files 1495 1494 -1
Lines 140024 140166 +142
========================================
+ Hits 131896 132043 +147
+ Misses 8128 8123 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
dbolduc
approved these changes
Sep 22, 2022
There was a problem hiding this comment.
Reviewed 17 of 17 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @coryan)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recapitulates the changes to make
BucketMetadataeasier to mock. This change adds modifiers for all the fields inObjectMetadataand removes the need forinternal::CommonMetadata<>.Since
internal::CommonMetadata<>is not needed, I deprecated the class, removed all references to the class or its header file, and refactor any useful code out of its header file.This is part of the work for #7142 and for #8929
This change is