Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pubsub): update subscription builders #9326

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Jun 22, 2022

We provide a few helpers to build the protos. While this may not be a
good idea in the long run, it is the current plan, so we need these
updates from time to time.


This change is Reviewable

We provide a few helpers to build the protos. While this may not be a
good idea in the long run, it is the current plan, so we need these
updates from time to time.
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Jun 22, 2022
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: e613eaa064a79f6c721ab138a89a5d717e23ed6b

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #9326 (196becc) into main (da8bc9f) will increase coverage by 0.00%.
The diff coverage is 99.10%.

@@           Coverage Diff            @@
##             main    #9326    +/-   ##
========================================
  Coverage   94.66%   94.66%            
========================================
  Files        1470     1470            
  Lines      134682   134794   +112     
========================================
+ Hits       127493   127603   +110     
- Misses       7189     7191     +2     
Impacted Files Coverage Δ
google/cloud/pubsub/snapshot_builder.h 100.00% <ø> (ø)
google/cloud/pubsub/topic_builder.h 100.00% <ø> (ø)
google/cloud/pubsub/subscription_builder.h 97.25% <97.87%> (+0.21%) ⬆️
google/cloud/pubsub/subscription_builder.cc 91.89% <100.00%> (+2.23%) ⬆️
google/cloud/pubsub/subscription_builder_test.cc 100.00% <100.00%> (ø)
...e/cloud/spanner/testing/cleanup_stale_instances.cc 72.22% <0.00%> (-5.56%) ⬇️
...integration_tests/schema_admin_integration_test.cc 98.88% <0.00%> (-1.12%) ⬇️
...le/cloud/storage/internal/curl_download_request.cc 87.87% <0.00%> (-0.68%) ⬇️
google/cloud/internal/curl_impl.cc 91.64% <0.00%> (-0.23%) ⬇️
google/cloud/pubsub/samples/samples.cc 92.18% <0.00%> (+0.07%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da8bc9f...196becc. Read the comment docs.

@coryan coryan marked this pull request as ready for review June 22, 2022 02:16
@coryan coryan requested a review from a team as a code owner June 22, 2022 02:16
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 196beccff97e2bb4a52e02f8bffb75e703d76746

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan merged commit 5f49313 into googleapis:main Jun 22, 2022
@coryan coryan deleted the feat-pubsub-update-subscription-builders branch June 22, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants