Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: simplify Bazel initialization #13411

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Jan 5, 2024

In v2.20.0 we introduced new Bazel WORKSPACE functions that should simplify the transition to Bazel v7. Now that the quickstart directories are using v2.20.0, we can change them to use these functions.

Part of the work for #13320


This change is Reviewable

In v2.20.0 we introduced new Bazel WORKSPACE functions that should
simplify the transition to Bazel v7. Now that the quickstart directories
are using v2.20.0, we can change them to use these functions.
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cee1146) 93.10% compared to head (9f55594) 93.10%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13411   +/-   ##
=======================================
  Coverage   93.10%   93.10%           
=======================================
  Files        2164     2164           
  Lines      188523   188571   +48     
=======================================
+ Hits       175531   175578   +47     
- Misses      12992    12993    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coryan coryan marked this pull request as ready for review January 5, 2024 19:48
@coryan coryan requested a review from a team as a code owner January 5, 2024 19:48
Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 131 files at r1, all commit messages.
Reviewable status: 6 of 131 files reviewed, all discussions resolved

@coryan coryan merged commit 68c1fe3 into googleapis:main Jan 5, 2024
60 of 61 checks passed
@coryan coryan deleted the cleanup-use-workspace-functions branch January 5, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants