feat: add PG.OID type #13127

thiagotnunes · 2023-11-14T05:26:20Z

Allows for using PG.OID type in parameterized queries and reading them from result sets.

This change is

Allows for using PG.OID type in parameterized queries and reading them from result sets.

…into oid

dbolduc · 2023-11-14T05:31:26Z

/gcbrun

dbolduc

Drive by: You will need to tell the build scripts about the new oid.h header.

google-cloud-cpp/google/cloud/spanner/CMakeLists.txt

Line 38 in 0cfd158

google_cloud_cpp_spanner # cmake-format: sort

and

google-cloud-cpp/google/cloud/spanner/google_cloud_cpp_spanner.bzl

Line 19 in 0cfd158

google_cloud_cpp_spanner_hdrs = [

google/cloud/spanner/integration_tests/data_types_integration_test.cc

google/cloud/spanner/oid.h

google/cloud/spanner/value_test.cc

google/cloud/spanner/oid.h

devbww · 2023-11-15T00:41:08Z

/gcbrun

google/cloud/spanner/oid.h

google/cloud/spanner/integration_tests/data_types_integration_test.cc

google/cloud/spanner/oid.h

codecov · 2023-11-15T01:18:16Z

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (27008ab) 92.99% compared to head (2399c6e) 93.00%.
Report is 1 commits behind head on main.

Files	Patch %	Lines
google/cloud/spanner/value.cc	89.47%	2 Missing ⚠️
...gle/cloud/spanner/internal/connection_impl_test.cc	94.44%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #13127   +/-   ##
=======================================
  Coverage   92.99%   93.00%           
=======================================
  Files        2137     2138    +1     
  Lines      185877   185950   +73     
=======================================
+ Hits       172865   172934   +69     
- Misses      13012    13016    +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…into oid

devbww · 2023-11-16T00:53:47Z

/gcbrun

google/cloud/spanner/integration_tests/data_types_integration_test.cc

google/cloud/spanner/oid.h

…into oid

devbww · 2023-11-17T00:28:39Z

/gcbrun

google/cloud/spanner/oid.h

google/cloud/spanner/value.cc

…into oid

devbww · 2023-11-20T04:28:52Z

/gcbrun

google/cloud/spanner/oid.h

google/cloud/spanner/value_test.cc

…into oid

devbww · 2023-11-20T23:51:28Z

/gcbrun

google/cloud/spanner/oid.h

devbww · 2023-11-21T02:45:17Z

/gcbrun

feat: add PG.OID type

6a4c0bf

Allows for using PG.OID type in parameterized queries and reading them from result sets.

thiagotnunes requested a review from a team as a code owner November 14, 2023 05:26

thiagotnunes had a problem deploying to external November 14, 2023 05:26 — with GitHub Actions Error

Merge branch 'main' of https://github.com/googleapis/google-cloud-cpp …

fc39895

…into oid

thiagotnunes temporarily deployed to external November 14, 2023 05:27 — with GitHub Actions Inactive

dbolduc reviewed Nov 14, 2023

View reviewed changes

devbww reviewed Nov 14, 2023

View reviewed changes

google/cloud/spanner/oid.h Outdated Show resolved Hide resolved

devbww reviewed Nov 14, 2023

View reviewed changes

google/cloud/spanner/oid.h Outdated Show resolved Hide resolved

larkee approved these changes Nov 14, 2023

View reviewed changes

google/cloud/spanner/oid.h Outdated Show resolved Hide resolved

fix: fixes pr comments

5f79a3f

thiagotnunes had a problem deploying to external November 14, 2023 23:37 — with GitHub Actions Error

fix: fixes formatting issues

6b755ee

thiagotnunes temporarily deployed to external November 14, 2023 23:51 — with GitHub Actions Inactive

devbww reviewed Nov 15, 2023

View reviewed changes

google/cloud/spanner/oid.h Outdated Show resolved Hide resolved

google/cloud/spanner/integration_tests/data_types_integration_test.cc Outdated Show resolved Hide resolved

coryan reviewed Nov 15, 2023

View reviewed changes

google/cloud/spanner/oid.h Outdated Show resolved Hide resolved

google/cloud/spanner/oid.h Outdated Show resolved Hide resolved

google/cloud/spanner/oid.h Outdated Show resolved Hide resolved

thiagotnunes added 3 commits November 16, 2023 11:45

fix: fixes pr comments

a22f24c

Merge branch 'main' of https://github.com/googleapis/google-cloud-cpp …

414b783

…into oid

Merge branch 'oid' of github.com:thiagotnunes/google-cloud-cpp into oid

2e0abdb

thiagotnunes had a problem deploying to external November 16, 2023 00:47 — with GitHub Actions Error

fix: formatting

a2dc2ea

thiagotnunes temporarily deployed to external November 16, 2023 00:50 — with GitHub Actions Inactive

devbww reviewed Nov 16, 2023

View reviewed changes

thiagotnunes added 2 commits November 17, 2023 09:50

Merge branch 'main' of https://github.com/googleapis/google-cloud-cpp …

ca6cdc6

…into oid

refactor: changes oid representation

a17e830

thiagotnunes had a problem deploying to external November 16, 2023 23:22 — with GitHub Actions Error

fix: formatting

f6ebee9

thiagotnunes had a problem deploying to external November 16, 2023 23:25 — with GitHub Actions Error

thiagotnunes added 2 commits November 17, 2023 10:27

fix: add missing header

2444926

refactor: use to_string instead of StrCat

61241c3

thiagotnunes temporarily deployed to external November 16, 2023 23:31 — with GitHub Actions Inactive

devbww reviewed Nov 17, 2023

View reviewed changes

google/cloud/spanner/oid.h Outdated Show resolved Hide resolved

google/cloud/spanner/oid.h Outdated Show resolved Hide resolved

google/cloud/spanner/value.cc Outdated Show resolved Hide resolved

thiagotnunes added 2 commits November 20, 2023 13:02

Merge branch 'main' of https://github.com/googleapis/google-cloud-cpp …

d1e4271

…into oid

fix: fixes pr comments

3405ab8

thiagotnunes temporarily deployed to external November 20, 2023 02:39 — with GitHub Actions Inactive

fix: use static cast on pg oid

8298a2a

thiagotnunes had a problem deploying to external November 20, 2023 05:30 — with GitHub Actions Error

devbww reviewed Nov 20, 2023

View reviewed changes

google/cloud/spanner/oid.h Outdated Show resolved Hide resolved

google/cloud/spanner/value_test.cc Outdated Show resolved Hide resolved

google/cloud/spanner/value_test.cc Outdated Show resolved Hide resolved

thiagotnunes added 2 commits November 21, 2023 09:59

Merge branch 'main' of https://github.com/googleapis/google-cloud-cpp …

d130d0f

…into oid

fix: address PR comments

1d055f6

thiagotnunes temporarily deployed to external November 20, 2023 23:30 — with GitHub Actions Inactive

devbww approved these changes Nov 21, 2023

View reviewed changes

google/cloud/spanner/oid.h Outdated Show resolved Hide resolved

google/cloud/spanner/oid.h Outdated Show resolved Hide resolved

google/cloud/spanner/oid.h Outdated Show resolved Hide resolved

fix: address PR comments

2399c6e

thiagotnunes temporarily deployed to external November 21, 2023 01:46 — with GitHub Actions Inactive

devbww merged commit f7c9022 into googleapis:main Nov 21, 2023
59 checks passed

thiagotnunes deleted the oid branch November 21, 2023 03:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add PG.OID type #13127

feat: add PG.OID type #13127

thiagotnunes commented Nov 14, 2023 •

edited by coryan

Loading

dbolduc commented Nov 14, 2023

dbolduc left a comment

devbww commented Nov 15, 2023

codecov bot commented Nov 15, 2023 •

edited

Loading

devbww commented Nov 16, 2023

devbww commented Nov 17, 2023

devbww commented Nov 20, 2023

devbww commented Nov 20, 2023

devbww commented Nov 21, 2023

feat: add PG.OID type #13127

feat: add PG.OID type #13127

Conversation

thiagotnunes commented Nov 14, 2023 • edited by coryan Loading

dbolduc commented Nov 14, 2023

dbolduc left a comment

Choose a reason for hiding this comment

devbww commented Nov 15, 2023

codecov bot commented Nov 15, 2023 • edited Loading

Codecov Report

devbww commented Nov 16, 2023

devbww commented Nov 17, 2023

devbww commented Nov 20, 2023

devbww commented Nov 20, 2023

devbww commented Nov 21, 2023

thiagotnunes commented Nov 14, 2023 •

edited by coryan

Loading

codecov bot commented Nov 15, 2023 •

edited

Loading