Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pubsub): url encode routing params on publish #12454

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Aug 24, 2023

Part of the work for #12232


This change is Reviewable

@dbolduc dbolduc temporarily deployed to internal August 24, 2023 04:44 — with GitHub Actions Inactive
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Aug 24, 2023
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (a97d711) 93.60% compared to head (6c51cc4) 93.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12454      +/-   ##
==========================================
- Coverage   93.60%   93.60%   -0.01%     
==========================================
  Files        2036     2036              
  Lines      180346   180346              
==========================================
- Hits       168819   168818       -1     
- Misses      11527    11528       +1     
Files Changed Coverage Δ
google/cloud/pubsub/subscriber_connection_test.cc 100.00% <ø> (+1.21%) ⬆️
...ub/internal/streaming_subscription_batch_source.cc 98.34% <100.00%> (ø)

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbolduc dbolduc marked this pull request as ready for review August 24, 2023 06:09
@dbolduc dbolduc requested a review from a team as a code owner August 24, 2023 06:09
@dbolduc dbolduc merged commit 828a9f7 into googleapis:main Aug 24, 2023
52 checks passed
@dbolduc dbolduc deleted the url-encode-pubsub-routing branch August 24, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants