Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(generator): create retry policy samples #11930

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Jun 21, 2023

This change is Reviewable

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jun 21, 2023
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Patch coverage: 94.25% and project coverage change: -0.01 ⚠️

Comparison is base (bbf1134) 93.66% compared to head (0d6b7aa) 93.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11930      +/-   ##
==========================================
- Coverage   93.66%   93.66%   -0.01%     
==========================================
  Files        1838     1838              
  Lines      166523   166694     +171     
==========================================
+ Hits       155978   156137     +159     
- Misses      10545    10557      +12     
Impacted Files Coverage Δ
...ogle/cloud/pubsub/samples/schema_client_samples.cc 98.36% <ø> (+1.39%) ⬆️
...e/cloud/pubsublite/samples/admin_client_samples.cc 98.36% <ø> (+1.39%) ⬆️
...d/pubsublite/samples/topic_stats_client_samples.cc 98.36% <ø> (+1.39%) ⬆️
generator/internal/sample_generator.cc 75.92% <66.66%> (-3.57%) ⬇️
...n/v1/samples/golden_kitchen_sink_client_samples.cc 98.24% <100.00%> (+1.27%) ⬆️
...lden/v1/samples/golden_rest_only_client_samples.cc 98.24% <100.00%> (+1.27%) ⬆️
...en/v1/samples/golden_thing_admin_client_samples.cc 98.24% <100.00%> (+1.27%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan marked this pull request as ready for review June 21, 2023 14:43
@coryan coryan requested a review from a team as a code owner June 21, 2023 14:43
generator/internal/sample_generator.cc Outdated Show resolved Hide resolved
@coryan coryan enabled auto-merge (squash) June 21, 2023 16:33
@coryan coryan disabled auto-merge June 21, 2023 16:41
@coryan coryan enabled auto-merge (squash) June 21, 2023 17:14
@coryan coryan merged commit 0ec6517 into googleapis:main Jun 21, 2023
@coryan coryan deleted the feat-generator-generate-retry-policy-samples branch June 21, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants