Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(impersonated): add impersonated credentials auth #1207
feat(impersonated): add impersonated credentials auth #1207
Changes from 14 commits
9ca71b8
9bd3590
b18dfc2
f91367c
c6e7c72
706a473
3caf0cb
fda2bab
30e81b4
c904057
28a448a
419a946
cf3b318
9b56c6c
c6012bc
1794dc5
70f0821
c4e6310
f53cb5b
910c18c
728573f
180fdf5
24d2f42
e66f7ce
8487662
48fe1db
e4f5917
6cb0e20
2cf98e9
a9752ee
aa2178e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For each of these properties, can we get a jsdoc annotation that describes what they are, and how they work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't
sourceClient
be anAuthClient
?OAuth2Client
is does not cover external account clients (BaseExternalAccountClient
) which can impersonated service accounts.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Likewise, perhaps we can get away with checking for just the
403
and404
case?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may want to add a test for
Impersonated
:google-auth-library-nodejs/test/test.index.ts
Line 31 in 3e0c4c9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed this one: 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest adding a new line after this and in between tests.