-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: fetch
(POC)
#618
Draft
danielbankhead
wants to merge
26
commits into
main
Choose a base branch
from
native-fetch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat!: fetch
(POC)
#618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warning: This pull request is touching the following templated files:
|
Really cool to see and thank you for digging into the numbers, both size wise and speed wise. Seems like there is a lot of work that still needs to happen on the node side for this to be competitive with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A proof-of-concept for migrating to native
fetch
. However, there are a few limitations today.No native
proxy
supportIt is possible to enable proxy support, however customers would have to install
unidici
downstream. Including it in this library would make it far too large. Here are some numbers:gaxios
undici
@google-cloud/storage
Adding
undici
would double the size of a downstream dependency like@google-cloud/storage
.However, there is discussion on adding the
ProxyAgent
within Node:Workaround
Potential workaround/fallback for customers:
Environment support
Additionally, it wasn't until recently that
undici
added env support forHTTP_PROXY
,HTTPS_PROXY
, &NO_PROXY
and it will take time for it to propagate to Node.js releases:Performance
The native
fetch
implementation is 26% - 28% slower thannode-fetch
according toundici
's benchmarks:node-fetch
Returning Streams
Native
fetch
returns a ReadableStream ('Web Streams') instead ofstream.Readable
. This may require a rewriting downstream for many applications that currently expects a Node stream.However, here's a simple way to resolve:
Additional Notes
https://nodejs.org/en/about/previous-releases
Fixes: #625
🦕