Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add google.api.api_version annotation to echo.proto #1484

Merged
merged 5 commits into from
Apr 9, 2024
Merged

feat: Add google.api.api_version annotation to echo.proto #1484

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1378107
feat: Add google.api.api_version annotation to echo.proto
parthea Mar 23, 2024
81c1a8c
update the api_version to a nonsense value to refelect that it should…
parthea Mar 23, 2024
28205f6
Merge branch 'main' into add-api-version-to-echo-proto
parthea Mar 24, 2024
606c9cf
Merge branch 'main' into add-api-version-to-echo-proto
parthea Apr 8, 2024
a377321
Address review feedback
parthea Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions schema/google/showcase/v1beta1/echo.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ service Echo {
// This service is meant to only run locally on the port 7469 (keypad digits
// for "show").
option (google.api.default_host) = "localhost:7469";
// See https://github.com/aip-dev/google.aip.dev/pull/1331
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link to AIP once aip-dev/google.aip.dev#1331 is merged

option (google.api.api_version) = "moose";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok and just to make sure.....we don't want a "real" version here?

I understand from generator/client perspective this is an opaque string, but there is something to be said about having good test data...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in a377321


// This method simply echoes the request. This method showcases unary RPCs.
rpc Echo(EchoRequest) returns (EchoResponse) {
Expand Down
Loading