feat: add iam and location mixin rest handlers #1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchudnov-g
approved these changes
Apr 19, 2023
| mixinDescriptors = map[string][]*descriptor.FileDescriptorProto{ | ||
| "google.longrunning.Operations": { | ||
| protodesc.ToFileDescriptorProto(longrunning.File_google_longrunning_operations_proto), | ||
| protodesc.ToFileDescriptorProto(longrunningpb.File_google_longrunning_operations_proto), |
There was a problem hiding this comment.
I am curious about the change to this import above and why location is different. (No particular concerns, I just want to learn.)
There was a problem hiding this comment.
In our Go proto world, we moved all generated code that has a gapic to a submodfule of https://pkg.go.dev/cloud.google.com/go, including the protobuf/grpc generated stubs so they can be versioned as one module, instead of in the separate google.golang.org/genproto (which has no semantic versioning). Locations doesn't have a GAPIC (but IAM and LRO do for "reasons"), so Locations remains in google.golang.org/genproto, while IAM was to cloud.google.com/go/iam/apiv1/iampb, and same for LRO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds generation of other mixin services to
genrestso that they can be routed from REGAPC requests to the gRPC handlers.Tested against Go GAPIC generator integration tests for mixins.
Fixes #1299