Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(snippetgen): add 2 placeholder values in lists #1013

Merged
merged 8 commits into from
Oct 8, 2021
Merged

chore(snippetgen): add 2 placeholder values in lists #1013

merged 8 commits into from
Oct 8, 2021

Conversation

busunkim96
Copy link
Contributor

Fixes #961

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 8, 2021
busunkim96
busunkim96 commented Oct 8, 2021
View reviewed changes
.../generated_samples/logging_generated_logging_v2_logging_service_v2_tail_log_entries_async.py
)

# Make the request
stream = await client.tail_log_entries([resource_names=['resource_names_value']])
stream = await client.tail_log_entries([resource_names=['resource_names_value_1', 'resource_names_value_2']])
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize this was broken earlier, but it is now tracked: #1014

@busunkim96 busunkim96 marked this pull request as ready for review October 8, 2021 16:00
@busunkim96 busunkim96 requested a review from a team as a code owner October 8, 2021 16:00
tseaver
tseaver suggested changes Oct 8, 2021
View reviewed changes
gapic/schema/wrappers.py Outdated Show resolved Hide resolved
@busunkim96 @tseaver
chore: consolidate logic for blob mock
39dfcdd 
Co-authored-by: Tres Seaver <tseaver@palladion.com>
@google-cla
Copy link

google-cla bot commented Oct 8, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Oct 8, 2021
@busunkim96 busunkim96 added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Oct 8, 2021
@busunkim96
Copy link
Contributor Author

CLA bot is confused as multiple people are listed on 39dfcdd. All authors have signed CLAs.

@google-cla
Copy link

google-cla bot commented Oct 8, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Oct 8, 2021
@busunkim96 busunkim96 added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Oct 8, 2021
@busunkim96 busunkim96 merged commit e511647 into master Oct 8, 2021
@busunkim96 busunkim96 deleted the snippetgen-repeated-values branch October 8, 2021 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

@software-dov software-dov software-dov approved these changes

@parthea parthea Awaiting requested review from parthea

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

snippetgen: add 2+ placeholder values for list field values
3 participants
@busunkim96 @tseaver @software-dov