fix: ignore types for imports generated from 'google.api_core' (#597)

Closes #596.
googleapis · Sep 15, 2020 · 8440e09 · 8440e09
1 parent b5279ef
commit 8440e09
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/gapic/schema/imp.py b/gapic/schema/imp.py
@@ -31,6 +31,6 @@ def __str__(self) -> str:
             answer = f"from {'.'.join(self.package)} {answer}"
         if self.alias:
             answer += f' as {self.alias}'
-        if self.module.endswith('_pb2'):
+        if self.module.endswith('_pb2') or 'api_core' in self.package:
             answer += '  # type: ignore'
         return answer
diff --git a/tests/unit/schema/test_imp.py b/tests/unit/schema/test_imp.py
@@ -35,6 +35,11 @@ def test_str_untyped_pb2():
     assert str(i) == 'from foo.bar import baz_pb2 as bacon  # type: ignore'
 
 
+def test_str_untyped_api_core():
+    i = imp.Import(package=('foo', 'api_core'), module='baz', alias='bacon')
+    assert str(i) == 'from foo.api_core import baz as bacon  # type: ignore'
+
+
 def test_str_eq():
     i1 = imp.Import(package=('foo', 'bar'), module='baz')
     i2 = imp.Import(package=('foo', 'bar'), module='baz')