[util] Ptr doesn't track byte length separately #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jswrenn
reviewed
Nov 27, 2023
jswrenn
reviewed
Nov 27, 2023
jswrenn
reviewed
Nov 27, 2023
Since raw pointer slice casts are now guaranteed to preserve element count [1], we no longer need to separately store the byte length of a `Ptr`. Instead, we can compute it from the raw pointer field. [1] rust-lang/reference#1417
joshlf
force-pushed
the
ptr-no-elems-count
branch
from
4e5d2be
to
eeb30fa
Compare
jswrenn
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since raw pointer slice casts are now guaranteed to preserve element count [1], we no longer need to separately store the byte length of a
Ptr. Instead, we can compute it from the raw pointer field.[1] rust-lang/reference#1417