[Ref] Remove unaligned constructors #1723
Conversation
|
@jswrenn Feel free to review, but I'm going to hold off on merging until the Fuchsia vendor CL passes all of its CQ tests. |
joshlf
force-pushed
the
remove-unaligned
branch
from
77e012b
to
56e1250
Compare
joshlf
force-pushed
the
remove-unaligned
branch
from
56e1250
to
376dab3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1723 +/- ##
==========================================
- Coverage 88.61% 88.11% -0.51%
==========================================
Files 16 16
Lines 5858 5720 -138
==========================================
- Hits 5191 5040 -151
- Misses 667 680 +13 ☔ View full report in Codecov by Sentry. |
Okay everything is passing other than asan tests, which are always flaky. I'm comfortable merging this. I'll mark as "merge when ready". |
| /// ``` | ||
| #[must_use = "has no side effects"] | ||
| #[inline(always)] | ||
| pub fn unaligned_from_bytes(source: B) -> Result<Ref<B, T>, SizeError<B, T>> { |
There was a problem hiding this comment.
Should these be removals, or deprecations?
There was a problem hiding this comment.
Removals; they're new as of 0.8. We've already deprecated all of the 0.7 methods, which have a different naming scheme.
Closes #1720