Improve IntoBytes derive error message #1713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlf
force-pushed
the
into-bytes-improve-unsized-error
branch
from
e38839b
to
b42cfb6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1713 +/- ##
=======================================
Coverage 88.79% 88.79%
=======================================
Files 16 16
Lines 5843 5846 +3
=======================================
+ Hits 5188 5191 +3
Misses 655 655 ☔ View full report in Codecov by Sentry. |
jswrenn
approved these changes
Sep 21, 2024
| #[inline(always)] | ||
| #[must_use] | ||
| #[allow(clippy::needless_maybe_sized)] | ||
| pub const fn size_of<T: Sized + ?core::marker::Sized>() -> usize { |
There was a problem hiding this comment.
This is such a cursed bound.
| --> tests/ui-nightly/struct.rs:129:8 | ||
| | | ||
| 129 | b: [u8], | ||
| | ^^^^ `IntoBytes` needs all field types to be `Sized` in order to determine whether there is inter-field padding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1708