Warn and detect edition of generated files #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the detection happens to have false positive, it will be removed in favor of keeping the warning only. Fixes google#444
ia0
commented
Apr 25, 2024
chris-dietz
pushed a commit
to chris-dietz/wasefire
that referenced
this pull request
Apr 29, 2024
If the detection happens to have false positive, it will be removed in favor of keeping the warning only. Fixes google#444
ia0
added a commit
to ia0/wasefire
that referenced
this pull request
May 16, 2024
This is useful to bypass the check for the book examples, which over-triggers when moving between before and after google#445.
ia0
added a commit
to ia0/wasefire
that referenced
this pull request
May 16, 2024
This is useful to bypass the check for the book examples, which over-triggers when moving between before and after google#445.
ia0
added a commit
that referenced
this pull request
May 16, 2024
This is useful to bypass the check for the book examples, which over-triggers when moving between before and after #445.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the detection happens to have false positive, it will be removed in favor of keeping the warning only.
Fixes #444