Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web UI Filter Options and Table formatting fixes #1518

Merged
merged 6 commits into from
Jul 31, 2024
Merged

Conversation

wajihyassine
Copy link
Member

@wajihyassine wajihyassine commented Jul 29, 2024

Description of the change

  • Fixes data table and text formatting causing overflow of text
  • Added back multi-sort data table
  • Expansion to the task id has now been moved to the right side next to the request id
  • Request List table has been cleaned up and request ids are now clickable allowing you to see request details on the right
  • Filter chips to filter by Task status (running or queued, successful, failed)
  • Filter chip to include or exclude job names
  • Task name is sorted by default
  • Added job_name in STORED_ATTRIBUTES to expose it in the API used for filtering
  • Dependency updates

Checklist

  • All tests were successful.
requestlist jobfilter

@wajihyassine wajihyassine marked this pull request as ready for review July 30, 2024 17:07
@wajihyassine wajihyassine self-assigned this Jul 30, 2024
Copy link
Collaborator

@jleaniz jleaniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some comments for you to review. Thanks!

turbinia/workers/__init__.py Show resolved Hide resolved
web/src/App.vue Show resolved Hide resolved
web/src/components/RequestDetails.vue Show resolved Hide resolved
web/src/components/RequestDetails.vue Outdated Show resolved Hide resolved
web/src/components/TaskList.vue Outdated Show resolved Hide resolved
@wajihyassine
Copy link
Member Author

  • @hacktobeer for optional high level review on the UI changes if it makes sense from user perspective. Planning to address Juan's comments tomorrow and merge then

@wajihyassine wajihyassine removed the request for review from hacktobeer July 31, 2024 16:11
@wajihyassine wajihyassine merged commit 7592fe1 into master Jul 31, 2024
13 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants